Repository navigation
fix(visualization): preserve nodes with duplicate names - #4512
Merged
seratch merged 1 commit intoAug 19, 2026
Merged
Conversation
tandede
force-pushed
the
agent/preserve-duplicate-graph-nodes
branch
from
August 19, 2026 11:59
df4343b to
a71b2a9
Compare
tandede
marked this pull request as ready for review
August 19, 2026 11:59
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a71b2a94f6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
tandede
force-pushed
the
agent/preserve-duplicate-graph-nodes
branch
from
August 19, 2026 13:30
a71b2a9 to
a001cb4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request fixes graph visualization when distinct agents, tools, MCP servers, or handoffs share the same display name.
Graphviz node identifiers were previously derived directly from display names, so colliding names were merged into one node, could create self-loops, and caused same-name agents to be skipped during traversal. A per-render identity registry now assigns identifiers by entity identity, generates deterministic identifiers only for collisions and reserved virtual-node names, and preserves the existing DOT output for collision-free graphs.
The implementation also preserves traversal through live
handoff()targets, honors caller-suppliedvisitednames, and detects collisions after DOT escaping so CR, LF, and CRLF variants cannot collapse into one identifier.Regression coverage includes cross-type name collisions, separate agents with the same name through both direct and
handoff()branches, escaped-identifier collisions, caller-supplied visited names, and an agent whose name matches the virtual start node.Test plan
pytest -q tests/test_visualization.py(19 passed).agents/skills/code-change-verification/scripts/run.sh(format, lint, type checking, and full tests passed)Issue number
N/A
Checks
.agents/skills/code-change-verification/scripts/run.sh