Repository navigation
fix: keep Codex verification for development sandboxed - #4508
Merged
Merged
Conversation
seratch
force-pushed
the
fix/sandbox-code-verification
branch
from
August 18, 2026 11:01
73cdddd to
df7cd8d
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: df7cd8d1a5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
seratch
force-pushed
the
fix/sandbox-code-verification
branch
from
August 18, 2026 11:40
df7cd8d to
816a4f8
Compare
seratch
enabled auto-merge (squash)
August 18, 2026 11:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes a verification policy that instructed Codex to execute repository-controlled verification outside its workspace sandbox.
It keeps the verification wrapper and its child processes sandboxed, skips only explicitly marked tests that require a native macOS sandbox when running under Codex, and executes those tests on a disposable macOS CI runner.
It also keeps the native pause/resume test's mock-tool log within its existing writable grant and replaces incidental
UnixLocalSandboxSessionusage in backend-neutral memory and event-sink tests with a process-free filesystem test session. RealUnixLocalSandboxSessioncoverage remains reserved for tests that intentionally validate native confinement and lifecycle behavior.Regression coverage verifies the sandboxed command, collection policy, native marker boundary, and process-free test-session behavior.