Repository navigation
fix(sandbox): validate view_image raster content - #4462
Merged
Merged
Conversation
Co-authored-by: Sylvester Kaczmarek <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request supersedes #4450 and fixes
view_imageso raster-looking filenames cannot authorize arbitrary bytes as structured image output.Raster formats now require one of the existing byte signatures, while SVG and SVGZ retain their released filename fallback through explicit case-insensitive suffix checks. Unlike #4450's latest implementation, this does not delegate the fallback decision to Python's mutable, environment-dependent MIME registry. Applications can customize that registry with
mimetypes.add_type(), which could otherwise map.pngor another raster extension toimage/svg+xmland reopen the filename-based bypass. Checking.svgand.svgzdirectly keeps the trust boundary deterministic while preserving UTF-8 prolog variants, UTF-16 SVG, and compressed SVGZ compatibility.Focused regression coverage verifies raster-extension rejection, registry-mutation resistance, signature-based raster acceptance, and the supported SVG/SVGZ compatibility cases.