Repository navigation
feat(sandbox): add Modal sandbox resource options - #4455
Merged
Merged
Conversation
Filimoa
changed the title
seratch
enabled auto-merge (squash)
August 16, 2026 03:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request adds optional
cpuandmemorysettings toModalSandboxClientOptions, matching Modal's scalar request and request-and-limit tuple forms. The settings are persisted in Modal session state and forwarded through fresh and snapshot-restored sandbox creation, while omitted values continue to use Modal's defaults.Test plan
UV_CACHE_DIR=/tmp/openai-agents-uv-cache uv run pytest tests/test_released_api_contract.py tests/extensions/sandbox/test_modal.py tests/sandbox/test_client_options.py tests/sandbox/test_compatibility_guards.pyenv UV_DEFAULT_INDEX=https://pypi.org/simple bash .agents/skills/code-change-verification/scripts/run.shIssue number
N/A
Checks
.agents/skills/code-change-verification/scripts/run.sh/reviewbefore submitting this PR