Repository navigation
fix: honor exact call approval decisions - #4447
Merged
Merged
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b7ec76c3a9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Co-authored-by: chiruu12 <[email protected]>
seratch
force-pushed
the
fix/per-call-approval-overrides
branch
from
August 15, 2026 23:31
b7ec76c to
109f633
Compare
3 of 4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request supersedes #4430 and fixes sticky approval defaults taking precedence over later exact per-call decisions. An exact decision now overrides the sticky default only for the matching call, while unrelated calls retain the sticky outcome. Reversing an exact decision also updates its effective status and rejection message consistently.
The change bumps the
RunStateschema from1.15to1.16. This does not add a new serialized field; it changes the semantics of the existing approval record. For example,approved: truetogether withrejected: ["call-2"]now means that calls are approved by default except forcall-2. Exact call-ID decisions are evaluated before sticky booleans.New snapshots use schema
1.16so older SDKs reject them instead of resuming with the previous precedence rule and potentially executing an explicitly rejected call. The current reader continues to accept older snapshots and preserves any explicit exact decisions they contain.The schema
1.16compatibility fixtures are reproduced from a schema1.15writer commit retained in repository history, with only the schema label canonicalized. The frozen payloads remain unchanged, and the provenance metadata records this distinction explicitly.Fixes #4429.