Repository navigation
fix(models): close all MultiProvider children after failures - #4438
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request fixes
MultiProvider.aclose()so one child provider's ordinary cleanup failure does not prevent later child providers from releasing their resources.asyncio.CancelledErrorimmediately.Test plan
Passed:
uv run pytest -q tests/models/test_map.py(17 passed)uv run pytest -q tests/models/test_responses_websocket_session.py(11 passed)uv run ruff checkuv run python .github/scripts/check_optional_truthiness.py src/agentsuv run ruff formatanduv run ruff check --fix(900 files unchanged)uv run mypy src/agents/models/multi_provider.pyThe full Windows test run reached 7,208 passed and 77 skipped, with remaining failures caused by local platform prerequisites unrelated to this change: the Unix
teecommand is unavailable, symlink creation is not permitted, two UTF-8 examples are decoded with the system GBK code page, and existing realtime Windows tests fail. Full mypy/pyright also report existing errors in untouched sandbox modules; pyright's only error issrc/agents/sandbox/util/tar_utils.py:161.Issue number
N/A
Checks
.agents/skills/code-change-verification/scripts/run.sh/reviewbefore submitting this PR