Repository navigation
fix: Responses context-management extra_args collision - #3185
Merged
Merged
Conversation
seratch
approved these changes
May 7, 2026
seratch
left a comment
seratch
left a comment
Member
There was a problem hiding this comment.
Looks good to me; let's see if Codex says 👍
Contributor
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Nice work! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
alfozan
changed the title
3 of 4 tasks
This was referenced May 8, 2026
RudrenduPaul
pushed a commit
to RudrenduPaul/openai-agents-python
that referenced
this pull request
Jun 21, 2026
### Summary Fix a false duplicate-argument error when a Responses request parameter is supplied through `ModelSettings.extra_args` and the first-class request field is only present as OpenAI's `omit` sentinel. ### Test plan - `make format` - `make lint` - `uv run pytest tests/models/test_openai_responses.py::test_build_response_create_kwargs_allows_extra_arg_when_explicit_arg_is_omitted tests/models/test_openai_responses.py::test_build_response_create_kwargs_rejects_duplicate_context_management_extra_args tests/models/test_openai_responses.py::test_build_response_create_kwargs_rejects_duplicate_extra_args_keys -q` - `uv run mypy src/agents/models/openai_responses.py tests/models/test_openai_responses.py` - `uv run pyright src/agents/models/openai_responses.py tests/models/test_openai_responses.py` - `git diff --check` ### Issue number N/A ### Checks - [x] I've added new tests (if relevant) - [ ] I've added/updated the relevant documentation - [x] I've run `make lint` and `make format` - [x] I've made sure tests pass where not blocked by unrelated local-only failures
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix a false duplicate-argument error when a Responses request parameter is supplied through
ModelSettings.extra_argsand the first-class request field is only present as OpenAI'somitsentinel.Test plan
make formatmake lintuv run pytest tests/models/test_openai_responses.py::test_build_response_create_kwargs_allows_extra_arg_when_explicit_arg_is_omitted tests/models/test_openai_responses.py::test_build_response_create_kwargs_rejects_duplicate_context_management_extra_args tests/models/test_openai_responses.py::test_build_response_create_kwargs_rejects_duplicate_extra_args_keys -quv run mypy src/agents/models/openai_responses.py tests/models/test_openai_responses.pyuv run pyright src/agents/models/openai_responses.py tests/models/test_openai_responses.pygit diff --checkIssue number
N/A
Checks
make lintandmake format