feat: #2346 add configurable timeout handling for function tools#2479
feat: #2346 add configurable timeout handling for function tools#2479
Conversation
seratch
changed the title
github-actions
Bot
added
enhancement
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7a69641114
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
seratch
force-pushed
the
feat/function-tool-timeouts
branch
from
7a69641 to
1d5000c
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1d5000cbf8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 12b6dead2a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
1 participant
This pull request adds configurable timeout handling for FunctionTool invocations, including per-tool timeout duration, timeout behavior (error_as_result or raise_exception), and optional timeout-specific error formatting. It wires timeout enforcement through both standard runner execution and realtime tool execution so behavior stays aligned across runtime paths. It also introduces ToolTimeoutError, updates docs for timeout usage and sync-thread caveats, and adds regression coverage for API defaults, compatibility, and timeout outcomes. This pull request resolves #2346.