You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit bb9babb
Browse filesBrowse the repository at this point in the historyBrowse files
Copy file name to clipboardExpand all lines: .agents/skills/code-change-verification/SKILL.md
+5-5Lines changed: 5 additions & 5 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -1,6 +1,6 @@
1
1
---
2
2
name: code-change-verification
3
-
description: Run the mandatory verification stack when changes affect runtime code, tests, or build/test behavior in the OpenAI Agents Python repository.
3
+
description: Run the required final formatting, lint, type, and test checks after eligible SDK changes pass review.
4
4
---
5
5
6
6
# Code Change Verification
@@ -15,8 +15,8 @@ Ensure work is only marked complete after formatting, linting, type checking, an
5.The scripts run `make format` first, then run `make lint`, `make typecheck`, and `make tests`in parallel with fail-fast semantics.
19
-
6.While the parallel steps are still running, the scripts emit periodic heartbeat updates so you can tell that work is still in progress.
18
+
5.On macOS/Linux, the script runs `make format`, `make lint`, `make typecheck`, and `make tests`sequentially and stops at the first failure. Parallelism inside each Make target, including pytest workers, is unchanged.
19
+
6.The Bash script streams each command's output directly. The Windows wrapper retains parallel lint, typecheck, and test steps with periodic heartbeat updates.
20
20
7. If any command fails, fix the issue, rerun the script, and report the failing output.
21
21
8. Confirm completion only when all commands succeed with no remaining issues.
22
22
@@ -46,14 +46,14 @@ On Linux, some Python packages with native extensions may require system package
46
46
- For a fresh checkout, or if dependencies are not installed or have changed, run `make sync` first to install dev requirements via `uv`.
47
47
- Run from the repository root with `make format` first, then `make lint`, `make typecheck`, and `make tests`.
48
48
- Do not skip steps; stop and fix issues immediately when a command fails.
49
-
-If you run the steps manually, you may parallelize `make lint`, `make typecheck`, and `make tests` after `make format` completes, but you must stop the remaining steps as soon as one fails.
49
+
-Run the manual steps sequentially and stop at the first failure. Keep the parallelism provided by each Make target.
50
50
- Re-run the full stack after applying fixes so the commands execute in the required order.
51
51
52
52
## Resources
53
53
54
54
### scripts/run.sh
55
55
56
-
-Executes`make format` first, then runs `make lint`, `make typecheck`, and `make tests`in parallel with fail-fast semantics from the repository root. It also emits periodic heartbeat updates while the parallel steps are still running. Prefer this entry point to preserve the required ordering while reducing total runtime.
56
+
-Runs`make format`, `make lint`, `make typecheck`, and `make tests`sequentially from the repository root. It streams output, preserves the first failure or cancellation status, and cleans up the active step's process group before continuing or exiting.
0 commit comments