Repository navigation
Commit 5e124bc
committed
do not await a lock to put the tail back
the bytes have already left the deque when the window decodes, so the local
pending is the only copy of them. awaiting output_lock to put it back is a
cancellation point, and a caller cancelled while a producer holds the lock loses
the character while the session carries on to read its continuation
appendleft is one synchronous call and deque is documented safe for it. every
holder of that lock is either a single append or a drain loop with no await
inside, so there is nothing for this to interleave with. the lock is there for
the multi step drain, not for one append
doing it without the lock removes the cancellation point rather than recovering
from it, so there is no window left to get wrong
test follows the reported repro. it drains the lead byte, holds the lock across
the deadline, cancels, and checks the byte is still there and the next window
still gives e acute1 parent f479af8 commit 5e124bc
2 files changed
Lines changed: 48 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
127 | 127 | | |
128 | 128 | | |
129 | 129 | | |
130 | | - | |
131 | | - | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
132 | 136 | | |
133 | 137 | | |
134 | 138 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
| 4 | + | |
4 | 5 | | |
5 | 6 | | |
6 | 7 | | |
| |||
250 | 251 | | |
251 | 252 | | |
252 | 253 | | |
| 254 | + | |
| 255 | + | |
| 256 | + | |
| 257 | + | |
| 258 | + | |
| 259 | + | |
| 260 | + | |
| 261 | + | |
| 262 | + | |
| 263 | + | |
| 264 | + | |
| 265 | + | |
| 266 | + | |
| 267 | + | |
| 268 | + | |
| 269 | + | |
| 270 | + | |
| 271 | + | |
| 272 | + | |
| 273 | + | |
| 274 | + | |
| 275 | + | |
| 276 | + | |
| 277 | + | |
| 278 | + | |
| 279 | + | |
| 280 | + | |
| 281 | + | |
| 282 | + | |
| 283 | + | |
| 284 | + | |
| 285 | + | |
| 286 | + | |
| 287 | + | |
| 288 | + | |
| 289 | + | |
| 290 | + | |
| 291 | + | |
| 292 | + | |
| 293 | + | |
| 294 | + | |
0 commit comments