Skip to content

Commit 528a53d

Browse files
committed
Add code ownership and required release review guidance
1 parent faf10fd commit 528a53d

2 files changed

Lines changed: 19 additions & 0 deletions

File tree

‎.github/CODEOWNERS‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
# Default ownership includes source, workflows, release/build tooling,
2+
# dependency manifests and locks, security policy, and this file.
3+
* @seratch @rm-openai

‎.github/RELEASING.md‎

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,22 @@
22

33
Release tags are created manually by authorized maintainers. Merging a release pull request does not create a tag.
44

5+
## Required release review
6+
7+
Before merging a release pull request, obtain at least one approving review from a code owner listed in `.github/CODEOWNERS`, resolve review conversations, and wait for all required checks to pass. The author cannot approve their own pull request. Changes after approval require a fresh code-owner review; the most recent reviewable push must also be approved by someone other than its pusher.
8+
9+
CODEOWNERS must be present on the pull request's base branch, and repository settings must enforce the review requirement. For the pull request that first adds CODEOWNERS, request approval from one of the listed maintainers explicitly.
10+
11+
### Administrator setup
12+
13+
For the existing `main` branch protection rule, require a pull request before merging, set required approvals to at least **1**, enable **Require review from Code Owners**, **Dismiss stale pull request approvals when new commits are pushed**, **Require approval of the most recent reviewable push**, and **Require conversation resolution before merging**. Apply these requirements to administrators and roles that can bypass branch protection; any emergency bypass exception requires separate approval and documentation.
14+
15+
Preserve every existing required check and its expected source, force-push and deletion restrictions, release-tag rules, environment deployment filters and reviewers, and trusted-publisher configuration. After CODEOWNERS merges and the settings are applied, verify that GitHub recognizes both owners and blocks an unapproved release pull request. Adding CODEOWNERS alone does not enforce approval.
16+
17+
The shared release policy requires code-owner approval before merging the release pull request; it does not require an additional environment approval gate. This repository's existing `pypi` deployment approval remains part of the publishing procedure below.
18+
19+
## Publish the reviewed release
20+
521
1. Merge the reviewed release pull request and record its actual merged commit SHA.
622
2. As an authorized maintainer, check that commit and its version before creating the tag. Replace the placeholders below:
723

0 commit comments

Comments
 (0)