Repository navigation
Commit 4a5f382
committed
fix: keep
Codex review noted that the previous duplicate-key filter — which ignores
create_kwargs entries whose value is the OpenAI omit sentinel — also lets
`extra_args={"stream": True}` slip through on the non-streaming path.
`get_response()` pins `create_kwargs["stream"]` to omit when stream=False
and then expects a `ChatCompletion`; if extra_args overrode it to True the
client would return an async stream that the non-streaming code path
cannot consume.
Mark `stream` as a reserved key that must always trigger duplicate-key
detection regardless of its current sentinel value. Other create_kwargs
slots (`reasoning_effort`, `tool_choice`, etc.) keep the omit-aware
behavior, so legitimate fall-through via extra_args still works.
Add two regression tests:
- extra_args={"stream": True} with stream=False must raise TypeError
- extra_args={"stream": False} with stream=True must raise TypeErrorstream reserved when checking extra_args duplicates1 parent 09555d5 commit 4a5f382
2 files changed
Lines changed: 72 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
49 | 49 | | |
50 | 50 | | |
51 | 51 | | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
52 | 62 | | |
53 | 63 | | |
54 | 64 | | |
| |||
431 | 441 | | |
432 | 442 | | |
433 | 443 | | |
434 | | - | |
| 444 | + | |
| 445 | + | |
| 446 | + | |
| 447 | + | |
| 448 | + | |
435 | 449 | | |
436 | 450 | | |
437 | 451 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
848 | 848 | | |
849 | 849 | | |
850 | 850 | | |
| 851 | + | |
| 852 | + | |
| 853 | + | |
| 854 | + | |
| 855 | + | |
| 856 | + | |
| 857 | + | |
| 858 | + | |
| 859 | + | |
| 860 | + | |
| 861 | + | |
| 862 | + | |
| 863 | + | |
| 864 | + | |
| 865 | + | |
| 866 | + | |
| 867 | + | |
| 868 | + | |
| 869 | + | |
| 870 | + | |
| 871 | + | |
| 872 | + | |
| 873 | + | |
| 874 | + | |
| 875 | + | |
| 876 | + | |
| 877 | + | |
| 878 | + | |
| 879 | + | |
| 880 | + | |
| 881 | + | |
| 882 | + | |
| 883 | + | |
| 884 | + | |
| 885 | + | |
| 886 | + | |
| 887 | + | |
| 888 | + | |
| 889 | + | |
| 890 | + | |
| 891 | + | |
| 892 | + | |
| 893 | + | |
| 894 | + | |
| 895 | + | |
| 896 | + | |
| 897 | + | |
| 898 | + | |
| 899 | + | |
| 900 | + | |
| 901 | + | |
| 902 | + | |
| 903 | + | |
| 904 | + | |
| 905 | + | |
| 906 | + | |
| 907 | + | |
0 commit comments