Skip to content

Commit 49660c5

Browse files
authored
fix(realtime): name the agent whose turn ended in agent_end (#5073)
1 parent 5e7afe4 commit 49660c5

2 files changed

Lines changed: 38 additions & 1 deletion

File tree

‎src/agents/realtime/session.py‎

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -620,6 +620,11 @@ async def on_event(self, event: RealtimeModelEvent) -> None:
620620
event.response_id is None or event.response_id == self._active_output_response_id
621621
)
622622
if is_active_response_ended:
623+
# A handoff inside the response has already moved _current_agent to the
624+
# new agent, so the agent that produced this turn is the one captured at
625+
# turn_started, the same snapshot the output guardrails use.
626+
ended_agent = self._active_output_response_agent or self._current_agent
627+
623628
# Clear guardrail state for next turn.
624629
self._item_transcripts.clear()
625630
self._item_guardrail_run_counts.clear()
@@ -629,7 +634,7 @@ async def on_event(self, event: RealtimeModelEvent) -> None:
629634

630635
await self._put_event(
631636
RealtimeAgentEndEvent(
632-
agent=self._current_agent,
637+
agent=ended_agent,
633638
info=self._event_info,
634639
)
635640
)

‎tests/realtime/test_session.py‎

Lines changed: 32 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
RealtimeAudioEnd,
2424
RealtimeAudioInterrupted,
2525
RealtimeError,
26+
RealtimeHandoffEvent,
2627
RealtimeRawModelEvent,
2728
RealtimeToolEnd,
2829
RealtimeToolStart,
@@ -54,6 +55,7 @@
5455
RealtimeSession,
5556
_PendingToolOutputSendError,
5657
)
58+
from agents.realtime.testing import ScriptedRealtimeModel
5759
from agents.run_context import RunContextWrapper
5860
from agents.tool import FunctionTool, function_tool, tool_namespace
5961
from agents.tool_context import ToolContext
@@ -330,6 +332,36 @@ async def close(self):
330332
assert session._responses_awaiting_guardrail_cleanup == set()
331333

332334

335+
@pytest.mark.asyncio
336+
async def test_agent_end_names_the_agent_whose_turn_ended_after_handoff():
337+
agent_b = RealtimeAgent(name="b")
338+
agent_a = RealtimeAgent(name="a", handoffs=[agent_b])
339+
model = ScriptedRealtimeModel(strict=False)
340+
session = RealtimeSession(model, agent_a, None, run_config={"async_tool_calls": False})
341+
await session.enter()
342+
try:
343+
await model.emit(RealtimeModelTurnStartedEvent(response_id="response_1"))
344+
await model.emit(
345+
RealtimeModelToolCallEvent(name="transfer_to_b", call_id="call_1", arguments="{}")
346+
)
347+
await model.emit(RealtimeModelTurnEndedEvent(response_id="response_1"))
348+
349+
events: list[Any] = []
350+
while not session._event_queue.empty():
351+
events.append(session._event_queue.get_nowait())
352+
finally:
353+
await session.close()
354+
355+
starts = [event for event in events if isinstance(event, RealtimeAgentStartEvent)]
356+
handoffs = [event for event in events if isinstance(event, RealtimeHandoffEvent)]
357+
ends = [event for event in events if isinstance(event, RealtimeAgentEndEvent)]
358+
assert [event.agent for event in starts] == [agent_a]
359+
assert [(event.from_agent, event.to_agent) for event in handoffs] == [(agent_a, agent_b)]
360+
# The turn that ended was produced by agent A; the handoff only changes who speaks next.
361+
assert [event.agent for event in ends] == [agent_a]
362+
assert session._current_agent is agent_b
363+
364+
333365
@pytest.mark.asyncio
334366
async def test_cancelling_one_close_waiter_does_not_cancel_cleanup():
335367
class BlockingCloseModel(_DummyModel):

0 commit comments

Comments
 (0)