Repository navigation
Commit 2cb8c3b
committed
Keep the SDK error for dtypes NumPy cannot parse
np.dtype() reports an unparseable dtype as either TypeError or
ValueError, and the handler only caught TypeError. A malformed
structured dtype such as {"names": ["x"], "formats": []} therefore
escaped as a NumPy ValueError instead of the UserError the consumer
gets for every other unsupported dtype.
Catch both, and cover the unresolvable case in the existing rejection
test alongside a dtype that resolves but is not supported.1 parent cf79d1d commit 2cb8c3b
2 files changed
Lines changed: 17 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
107 | 107 | | |
108 | 108 | | |
109 | 109 | | |
110 | | - | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
111 | 113 | | |
112 | 114 | | |
113 | | - | |
| 115 | + | |
114 | 116 | | |
115 | 117 | | |
116 | 118 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1366 | 1366 | | |
1367 | 1367 | | |
1368 | 1368 | | |
1369 | | - | |
| 1369 | + | |
| 1370 | + | |
| 1371 | + | |
| 1372 | + | |
| 1373 | + | |
| 1374 | + | |
| 1375 | + | |
| 1376 | + | |
| 1377 | + | |
| 1378 | + | |
| 1379 | + | |
| 1380 | + | |
1370 | 1381 | | |
1371 | 1382 | | |
1372 | 1383 | | |
1373 | 1384 | | |
1374 | 1385 | | |
1375 | 1386 | | |
1376 | 1387 | | |
1377 | | - | |
| 1388 | + | |
1378 | 1389 | | |
1379 | 1390 | | |
1380 | 1391 | | |
| |||
0 commit comments