Repository navigation
Commit 06ff1f8
committed
fix(sessions): arm a terminal checkpoint only from the successful finalize path
Three review findings landed on the same rule, so this replaces it rather than
subtracting another case from it. The checkpoint replays one Session append, so
it may only be armed when that append really is all the run has left.
Ownership is now decided by terminal_checkpoint_owner() and opted into by the
caller, instead of being inferred from the step:
- Only the finalize path that saw every output guardrail succeed passes
settle_terminal_output. The tripwire, guardrail-error, and max-turns saves
reach the same helper and must not arm a checkpoint, because an error there
has to surface on the next resume rather than be settled away.
- A compaction-aware Session also owes a deferred compaction for the batch,
which the checkpoint does not carry. Those runs keep the existing
non-resumable behavior instead of settling a batch whose maintenance the
replay would skip.
resumed_write_owner() now resolves the owning state at the call sites, so
save_resumed_turn_items() forwards an already resolved owner and its signature
is unchanged.1 parent d9b541f commit 06ff1f8
5 files changed
Lines changed: 206 additions & 54 deletions
File tree
- src/agents
- run_internal
- tests
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
136 | 136 | | |
137 | 137 | | |
138 | 138 | | |
139 | | - | |
140 | 139 | | |
141 | 140 | | |
142 | 141 | | |
143 | 142 | | |
144 | 143 | | |
145 | 144 | | |
146 | 145 | | |
| 146 | + | |
147 | 147 | | |
148 | 148 | | |
149 | 149 | | |
| 150 | + | |
150 | 151 | | |
151 | 152 | | |
152 | 153 | | |
| |||
1191 | 1192 | | |
1192 | 1193 | | |
1193 | 1194 | | |
1194 | | - | |
| 1195 | + | |
1195 | 1196 | | |
1196 | 1197 | | |
1197 | 1198 | | |
| |||
1393 | 1394 | | |
1394 | 1395 | | |
1395 | 1396 | | |
1396 | | - | |
1397 | | - | |
1398 | | - | |
1399 | | - | |
| 1397 | + | |
| 1398 | + | |
| 1399 | + | |
| 1400 | + | |
| 1401 | + | |
| 1402 | + | |
| 1403 | + | |
| 1404 | + | |
| 1405 | + | |
1400 | 1406 | | |
1401 | 1407 | | |
1402 | 1408 | | |
| |||
1409 | 1415 | | |
1410 | 1416 | | |
1411 | 1417 | | |
| 1418 | + | |
| 1419 | + | |
1412 | 1420 | | |
1413 | 1421 | | |
1414 | 1422 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
42 | 42 | | |
43 | 43 | | |
44 | 44 | | |
45 | | - | |
46 | 45 | | |
47 | 46 | | |
| 47 | + | |
48 | 48 | | |
49 | 49 | | |
50 | 50 | | |
| |||
619 | 619 | | |
620 | 620 | | |
621 | 621 | | |
| 622 | + | |
622 | 623 | | |
623 | 624 | | |
624 | 625 | | |
625 | 626 | | |
626 | 627 | | |
627 | 628 | | |
628 | 629 | | |
629 | | - | |
630 | | - | |
631 | | - | |
632 | | - | |
| 630 | + | |
| 631 | + | |
| 632 | + | |
| 633 | + | |
633 | 634 | | |
634 | 635 | | |
635 | 636 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
173 | 173 | | |
174 | 174 | | |
175 | 175 | | |
176 | | - | |
177 | 176 | | |
178 | 177 | | |
179 | 178 | | |
180 | 179 | | |
181 | 180 | | |
182 | 181 | | |
183 | 182 | | |
| 183 | + | |
184 | 184 | | |
185 | 185 | | |
186 | 186 | | |
187 | 187 | | |
| 188 | + | |
188 | 189 | | |
189 | 190 | | |
190 | 191 | | |
| |||
387 | 388 | | |
388 | 389 | | |
389 | 390 | | |
| 391 | + | |
390 | 392 | | |
391 | 393 | | |
392 | 394 | | |
| |||
395 | 397 | | |
396 | 398 | | |
397 | 399 | | |
398 | | - | |
| 400 | + | |
| 401 | + | |
| 402 | + | |
399 | 403 | | |
400 | 404 | | |
401 | 405 | | |
| |||
497 | 501 | | |
498 | 502 | | |
499 | 503 | | |
500 | | - | |
| 504 | + | |
| 505 | + | |
501 | 506 | | |
502 | 507 | | |
503 | 508 | | |
| |||
562 | 567 | | |
563 | 568 | | |
564 | 569 | | |
565 | | - | |
| 570 | + | |
566 | 571 | | |
567 | 572 | | |
568 | 573 | | |
| |||
587 | 592 | | |
588 | 593 | | |
589 | 594 | | |
590 | | - | |
| 595 | + | |
591 | 596 | | |
592 | 597 | | |
593 | 598 | | |
| |||
619 | 624 | | |
620 | 625 | | |
621 | 626 | | |
622 | | - | |
623 | | - | |
624 | | - | |
| 627 | + | |
| 628 | + | |
| 629 | + | |
| 630 | + | |
| 631 | + | |
| 632 | + | |
625 | 633 | | |
626 | 634 | | |
627 | 635 | | |
| |||
636 | 644 | | |
637 | 645 | | |
638 | 646 | | |
| 647 | + | |
639 | 648 | | |
640 | | - | |
| 649 | + | |
641 | 650 | | |
642 | 651 | | |
643 | | - | |
| 652 | + | |
644 | 653 | | |
645 | 654 | | |
646 | 655 | | |
| |||
1126 | 1135 | | |
1127 | 1136 | | |
1128 | 1137 | | |
1129 | | - | |
| 1138 | + | |
| 1139 | + | |
| 1140 | + | |
| 1141 | + | |
1130 | 1142 | | |
1131 | 1143 | | |
1132 | 1144 | | |
| |||
1136 | 1148 | | |
1137 | 1149 | | |
1138 | 1150 | | |
| 1151 | + | |
1139 | 1152 | | |
1140 | 1153 | | |
1141 | 1154 | | |
1142 | | - | |
| 1155 | + | |
| 1156 | + | |
| 1157 | + | |
| 1158 | + | |
1143 | 1159 | | |
| 1160 | + | |
| 1161 | + | |
| 1162 | + | |
1144 | 1163 | | |
1145 | 1164 | | |
1146 | 1165 | | |
| |||
1167 | 1186 | | |
1168 | 1187 | | |
1169 | 1188 | | |
1170 | | - | |
| 1189 | + | |
| 1190 | + | |
| 1191 | + | |
| 1192 | + | |
1171 | 1193 | | |
| 1194 | + | |
| 1195 | + | |
1172 | 1196 | | |
1173 | 1197 | | |
1174 | 1198 | | |
| |||
1457 | 1481 | | |
1458 | 1482 | | |
1459 | 1483 | | |
| 1484 | + | |
1460 | 1485 | | |
1461 | 1486 | | |
1462 | 1487 | | |
| |||
1655 | 1680 | | |
1656 | 1681 | | |
1657 | 1682 | | |
| 1683 | + | |
1658 | 1684 | | |
1659 | 1685 | | |
1660 | 1686 | | |
| |||
1920 | 1946 | | |
1921 | 1947 | | |
1922 | 1948 | | |
| 1949 | + | |
1923 | 1950 | | |
1924 | 1951 | | |
1925 | 1952 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
81 | 81 | | |
82 | 82 | | |
83 | 83 | | |
84 | | - | |
| 84 | + | |
| 85 | + | |
85 | 86 | | |
86 | 87 | | |
87 | 88 | | |
| |||
722 | 723 | | |
723 | 724 | | |
724 | 725 | | |
725 | | - | |
| 726 | + | |
726 | 727 | | |
727 | | - | |
728 | | - | |
729 | | - | |
730 | | - | |
731 | | - | |
732 | | - | |
| 728 | + | |
| 729 | + | |
| 730 | + | |
| 731 | + | |
| 732 | + | |
| 733 | + | |
| 734 | + | |
| 735 | + | |
| 736 | + | |
| 737 | + | |
| 738 | + | |
| 739 | + | |
| 740 | + | |
| 741 | + | |
| 742 | + | |
| 743 | + | |
| 744 | + | |
| 745 | + | |
733 | 746 | | |
734 | | - | |
| 747 | + | |
| 748 | + | |
| 749 | + | |
735 | 750 | | |
736 | 751 | | |
737 | | - | |
| 752 | + | |
| 753 | + | |
| 754 | + | |
738 | 755 | | |
739 | 756 | | |
740 | 757 | | |
741 | 758 | | |
742 | 759 | | |
743 | | - | |
744 | | - | |
745 | | - | |
746 | | - | |
| 760 | + | |
| 761 | + | |
| 762 | + | |
| 763 | + | |
747 | 764 | | |
748 | 765 | | |
749 | 766 | | |
750 | | - | |
| 767 | + | |
| 768 | + | |
| 769 | + | |
| 770 | + | |
| 771 | + | |
| 772 | + | |
| 773 | + | |
| 774 | + | |
| 775 | + | |
| 776 | + | |
| 777 | + | |
| 778 | + | |
| 779 | + | |
| 780 | + | |
| 781 | + | |
| 782 | + | |
| 783 | + | |
| 784 | + | |
| 785 | + | |
| 786 | + | |
| 787 | + | |
| 788 | + | |
| 789 | + | |
| 790 | + | |
751 | 791 | | |
752 | 792 | | |
753 | 793 | | |
| |||
761 | 801 | | |
762 | 802 | | |
763 | 803 | | |
764 | | - | |
| 804 | + | |
| 805 | + | |
| 806 | + | |
| 807 | + | |
| 808 | + | |
765 | 809 | | |
766 | 810 | | |
767 | 811 | | |
| |||
773 | 817 | | |
774 | 818 | | |
775 | 819 | | |
776 | | - | |
777 | | - | |
778 | | - | |
779 | | - | |
780 | | - | |
781 | | - | |
782 | | - | |
783 | | - | |
784 | | - | |
| 820 | + | |
785 | 821 | | |
786 | 822 | | |
787 | 823 | | |
| |||
0 commit comments