Repository navigation
fix: Preserve unrelated MCP server tool caches during invalidation - #1977
Conversation
🦋 Changeset detectedLatest commit: 331ede1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
markstuart-oai
left a comment
There was a problem hiding this comment.
Reviewed at 331ede1. Removing the prefix scan fixes the cross-server eviction while the existing per-server key registry preserves agent-specific and custom cache-key invalidation. The regression covers both repeated invalidation and an uncached base server, and verifies that the colon-suffixed server remains cached until explicitly invalidated. No blocking findings.
Verified all 16 hosted checks passing at this head, including Node 22/24, Windows, coverage and CodeQL. Source and existing-test review only; I did not run repository tests or builds.
Summary
Invalidating
docscan currently evict cached tools for an unrelated server nameddocs:extrawhendocshas no registered cache keys, including after a previous invalidation. Remove the fallback prefix scan so invalidation uses registered keys or the exact server name.Add regression coverage for never-cached and repeatedly invalidated server names, confirm intended-server invalidation still works, and include an
@openai/agents-corepatch changeset.Test plan
pnpm test:review --maxWorkers=2; this profile excludes the repository's five optional Docker/local-process test files.Issue number
Fixes #1976.
Checks