fix: #1122 hide ignored handoffs without breaking managed continuations#1123
Merged
fix: #1122 hide ignored handoffs without breaking managed continuations#1123
Conversation
🦋 Changeset detectedLatest commit: 0029d6a The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request resolves #1122 by narrowing the managed-resume fix to the actual streaming failure boundary. For Responses API managed conversations, request inputs are only added to the server-side conversation after the response completes, so a streamed run that is interrupted after an early SSE but before
response_donemust resend the accepted handoff output and any supplemental ignored-handoff acknowledgements on resume.The change removes the streaming-only logic that treated an in-progress managed turn as already committed during
primeFromState(). Non-stream resumes still keep their existing suppression behavior, while streamed resumes now replay the current turn inputs until a completed response has actually been observed. Regression coverage now locks in that pre-response_donecancellation path so the resumed managed request includes the required handoff acknowledgements again.