fix: avoid replaying orphan hosted shell calls across turns#1099
Merged
fix: avoid replaying orphan hosted shell calls across turns#1099
Conversation
🦋 Changeset detectedLatest commit: 9bd7e23 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 09455233b8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes a multi-turn runner bug where hosted
shell_callitems without matchingshell_call_outputresults could be replayed into a follow-up Responses request, which can trigger provider-side errors such as missing tool output on the next turn.It updates the default turn assembly in
packages/agents-core/src/runner/turnPreparation.tsandpackages/agents-core/src/runner/items.tsto prune orphan tool calls only from runner-generated continuity history while preserving caller-provided input. It also hardenspackages/agents-core/src/runner/sessionPersistence.tsso session history cannot reintroduce the same orphan hosted shell items, while still keeping fresh caller-provided pending shell calls intact. The change adds targeted regressions inpackages/agents-core/test/run.test.ts,packages/agents-core/test/run.stream.test.ts,packages/agents-core/test/runner/items.helpers.test.ts, andpackages/agents-core/test/runner/sessionPersistence.test.ts, and includes the untracked patch changeset file.changeset/calm-spoons-sparkle.mdfor release coverage.see also: openai/openai-agents-python#2665