feat: #855 add opt-in model retry policies#1083
Merged
Conversation
🦋 Changeset detectedLatest commit: dc07675 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
88bb933 to
3b7c1d5
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9dd72ddaa9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
6 tasks
This was referenced Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds opt-in model retry policies across
@openai/agents-core,@openai/agents-openai, and@openai/agents-extensions. The core change introducesmodelSettings.retry, publicretryPolicieshelpers, deep merging for nested retry settings, and a shared runner-owned retry path inpackages/agents-core/src/model.ts,packages/agents-core/src/runner/modelRetry.ts,packages/agents-core/src/run.ts,packages/agents-core/src/runner/modelSettings.ts, andpackages/agents-core/src/agentToolRunConfig.ts.It also updates provider integrations so OpenAI and AI SDK models expose retry advice instead of making the final retry decision themselves. The OpenAI client calls now force
maxRetries: 0so SDK-level retries cannot bypass the runner policy, while safety vetoes still block retries for aborted requests, streams that already emitted visible output, and websocket requests that may already have been accepted.This is still opt-in, but if a developers writes some code, this solution could resolve #855. We won't enable such by default, so when we release this enhancement, we'll add guides in documentation.