perf: speed up tracing and realtime unit tests#1027
Merged
Conversation
🦋 Changeset detectedLatest commit: fa3e29f The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves unit test execution time. It updates the Vitest worker pool to use threads, removes real-time waiting from the slowest tracing and realtime session tests, and adds a patch changeset for
@openai/agents-coreand@openai/agents-realtime.The main goal is to preserve coverage while reducing wasted wall-clock time in the existing unit suite. Local same-machine benchmarking showed
pnpm testimproving from about 6.6s average before the change to about 5.7s after it, with warm runs improving from about 5.0s to about 3.8s, roughly a 15 to 20 percent reduction overall.The test changes are focused and incremental:
vitest.config.tsswitches the suite to thethreadspool.packages/agents-core/test/tracing.test.tsreplaces a real shutdown wait with fake timers.packages/agents-realtime/test/realtimeSession.test.tsandpackages/agents-realtime/test/stubs.tsreplace polling-heavy waits with direct event and promise synchronization and make timeout tests deterministic.