Repository navigation
fix(cli): require verification for no-change patches - #1020
Conversation
verification is required for verified and no_change outcomes, so the requested result format matches the enforced check.
verification is required for verified and no_change outcomes, so the requested result format matches the enforced check.verification is required for verified and no_change outcomes, so the requested result format matches the enforced check.
verification is required for verified and no_change outcomes, so the requested result format matches the enforced check.fix(cli): correct typo in patch result contract.
…nge-verification-1020
|
Thanks, Arunim. I merged current main and kept the production fix to the existing verification check and its response instructions. The before/after comparison confirms the bug: main returns success for Validation is complete: 72 focused patch tests passed, and both full SDK runs passed with 3,242 tests passing, 50 skipped, and no failures in each run. Builds, type checks, formatting, and GitHub CI passed. The review found no further changes needed. I also ran the built CLI with a real model on a benign local fixture. It completed with full coverage, no findings, and unchanged source files. That scan did not produce the bad patch response; the controlled regression tests establish that part of the fix. |
Summary
scan --patchcould return success after the model reportedno_changewithout explaining how it verified the finding. That result now becomesfailedwith exit code 2, matching the existing check forverifiedresults.Fixes #1019. Original fix by @arunimshukla.
Changes
no_change, blocked, and failed behavior.Testing
no_changeverification return success. All eight selected cases pass with this fix. These tests supply model responses explicitly.Risk and rollout
This checks whether a verification explanation is present. It cannot establish whether that explanation is true. Valid
no_changeresults remain accepted; missing or blank verification now fails. No CLI options or output fields change.Public disclosure review