Repository navigation
fix: correct invalid 'xhigh' reasoning effort in README - #99
Merged
dkundel-openai merged 1 commit intoApr 8, 2026
Merged
Conversation
Closes openai#77 Updated README to replace unsupported 'xhigh' value with 'high' to prevent configuration errors.
There was a problem hiding this comment.
Pull request overview
Updates the documentation example configuration to use a valid model_reasoning_effort value, aligning the README with the config parser’s accepted variants and preventing codex login/plugin setup errors.
Changes:
- Replaced unsupported
model_reasoning_effort = "xhigh"withmodel_reasoning_effort = "high"in the README example.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
robinmordasiewicz
added a commit
to f5-sales-demo/codex-plugin-cc
that referenced
this pull request
Jul 24, 2026
* Fix working-tree review crash on untracked directories (openai#166) * fix: skip untracked directories in review context * fix: skip broken untracked symlinks in reviews * fix: respect SHELL on Windows for Git Bash (openai#178) * Use app-server auth status for Codex readiness (openai#177) * Use app-server auth status for Codex readiness * fix: reuse existing app server for auth checks * fix: inherit process.env in app-server spawn when no explicit env is provided (openai#159) `SpawnedCodexAppServerClient.initialize()` passes `this.options.env` to `spawn()`, but no caller ever sets `env` in options. In Node.js, passing `undefined` for `env` gives the child process **no** environment variables, breaking any model provider that relies on env vars (e.g. DATABRICKS_TOKEN). Fall back to `process.env` when `this.options.env` is not set, matching the existing pattern in `broker-lifecycle.mjs` and `codex-companion.mjs`. Co-authored-by: Isaac Co-authored-by: Bhuvanesh Sridharan <[email protected]> * fix: gracefully handle unsupported thread/name/set on older Codex CLI (openai#126) * fix: gracefully handle unsupported thread/name/set on older Codex CLI Codex CLI v0.118.0 does not recognize the thread/name/set JSON-RPC method, causing startThread() to throw. Thread naming is cosmetic (for job log labels) and should not block thread creation. Wraps the call in try/catch so it fails silently on older CLI versions. Fixes openai#119 * refactor: only suppress unsupported-method errors for thread/name/set Address Codex review feedback: the bare catch swallowed all errors including auth, network, and server failures. Now only suppresses errors containing 'unknown variant' or 'unknown method' (the specific error older CLI versions return) and rethrows everything else. * codex: scope implicit resume-last selection to the current Claude session (openai#83) Co-authored-by: VOIDXAI <[email protected]> * codex: scope default cancel selection to the current Claude session (openai#84) Co-authored-by: VOIDXAI <[email protected]> * fix: avoid embedding large adversarial review diffs (openai#179) * fix: avoid embedding large adversarial review diffs * fix: preserve untracked content in lightweight review * address comments * fix: handle ENOBUFS type check in git diff sizing * bump: update plugin version to 1.0.3 (openai#180) * codex: honor --cwd when reporting session runtime (openai#35) * codex: honor --cwd when reporting session runtime * codex: keep session runtime lookup scoped to callers --------- Co-authored-by: VOIDXAI <[email protected]> * fix: declare model in codex-rescue agent frontmatter (openai#169) * fix: declare model in codex-rescue agent frontmatter The codex-rescue agent had no model field, leaving Claude Code to assign whatever default it chooses. As a thin forwarding wrapper that issues a single Bash call, this agent is well-suited to the haiku tier; declaring it explicitly ensures a predictable cost profile and tier guarantee. Co-Authored-By: Claude Code <[email protected]> * Update codex-rescue.md --------- Co-authored-by: claude[bot] <[email protected]> Co-authored-by: Claude Code <[email protected]> Co-authored-by: Dominik Kundel <[email protected]> * fix: correct invalid 'xhigh' reasoning effort in README (openai#99) Closes openai#77 Updated README to replace unsupported 'xhigh' value with 'high' to prevent configuration errors. * fix: quote \$ARGUMENTS in cancel, result, and status commands (openai#168) Unquoted \$ARGUMENTS in the ! shell commands allowed shell metacharacters in user-supplied job IDs to be expanded before Node received them (e.g., `task-123; malicious-cmd` would execute the trailing command). This is inconsistent with review.md and adversarial-review.md, which both wrap "$ARGUMENTS" in double quotes. Co-authored-by: claude[bot] <[email protected]> Co-authored-by: Claude Code <[email protected]> * fix: route /codex:rescue through the Agent tool to stop Skill recursion (openai#234) (openai#235) * fix: route /codex:rescue through the Agent tool to stop Skill recursion (openai#234) `/codex:rescue` previously combined two things that together caused a hang: - `context: fork` in the frontmatter, which spawns a `general-purpose` subagent for the command body. - Body prose "Route this request to the `codex:codex-rescue` subagent." without naming the transport. When the main agent called `Skill(codex:rescue)` programmatically, the fork resolved the ambiguous prose by trying `Skill(codex:codex-rescue)` (unknown skill) and then falling back to `Skill(codex:rescue)`, which re-entered this command and hung the session until the user cancelled. No Codex job was ever created. Naming the transport as `Agent(codex:codex-rescue)` alone is not enough: forked general-purpose subagents do not expose the `Agent` tool, so the forked runner cannot reach the subagent that way either. The minimal fix is therefore two coordinated changes: - Drop `context: fork` so the command body runs inline in the calling agent's context, where `Agent` is in scope. - Say explicitly "use the `Agent` tool with `subagent_type: "codex:codex-rescue"`", and call out that `Skill(codex:codex-rescue)` and `Skill(codex:rescue)` are not valid routing paths. Add `Agent` to `allowed-tools` so the call does not prompt for permission. Everything else in rescue.md (resume-candidate check, flag handling, background/foreground semantics, operating rules) is unchanged. The `codex:codex-rescue` subagent itself is unchanged. Tests pin the new allow-list, the explicit `subagent_type`, the ban on `Skill(codex:codex-rescue)`, and the absence of `context: fork`. The existing "run the `codex:codex-rescue` subagent in the background" assertion continues to hold since that sentence still reads correctly with the Agent-tool transport. Fixes openai#234 * test: match quoted result and cancel command arguments --------- Co-authored-by: Dominik Kundel <[email protected]> * fix: bump plugin version to 1.0.4 (openai#244) * feat: add Claude session transfer command (openai#374) * fix: bump plugin version to 1.0.5 (openai#398) * Remove shell expansion for git commands (openai#447) * Remove shell expansion for git commands * Version bump --------- Co-authored-by: Dominik Kundel <[email protected]> Co-authored-by: Bhuvanesh Sridharan <[email protected]> Co-authored-by: Bhuvanesh Sridharan <[email protected]> Co-authored-by: Trevin Chow <[email protected]> Co-authored-by: VOIDXAI <[email protected]> Co-authored-by: VOIDXAI <[email protected]> Co-authored-by: xiaolai <[email protected]> Co-authored-by: claude[bot] <[email protected]> Co-authored-by: Claude Code <[email protected]> Co-authored-by: Manav Agarwal <[email protected]> Co-authored-by: Friende <[email protected]> Co-authored-by: stefanstokic-oai <[email protected]> Co-authored-by: bryane-oai <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #77
Updated README to replace unsupported 'xhigh' value with 'high' to prevent configuration errors.