Repository navigation
fix(args): preserve equals signs in inline option values - #808
Open
sylvesterkaczmarek wants to merge 1 commit into
Open
sylvesterkaczmarek wants to merge 1 commit into
sylvesterkaczmarek wants to merge 1 commit into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Edo771977
added a commit
to Edo771977/codex-plugin-cc
that referenced
this pull request
Oct 16, 2026
Import upstream openai#809 and openai#811, and the tests of openai#808
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #807. Inline value flags such as
--base=feature=xwere parsed withsplit("=", 2), which discards everything after the second equals sign. Git ref names can legitimately contain=, so/codex:review --base=feature=xsilently changed the intended base.indexOfandslice, retaining the entire value after it.--passthrough.=, values consisting entirely of=, empty values, aliases, booleans, missing values, raw-argument tokenization, and passthrough.Verification
npm test, including 9 new tests).node --checkpassed for both modified source and test files, andgit diff --checkpassed.No live review against an actual branch with an equals sign was needed; the parser is tested directly.
Maintenance validation on 7 November 2026
The complete standalone branch suite passed 100 tests, including inline values containing equals signs.
The four PRs merged without conflicts in a local checkout. All 109 tests passed, together with the version check and TypeScript build. The unchanged upstream checkout passed 91 tests and its build. Runtime tests used fake app-server fixtures and isolated test state, without live model requests or account credentials. Native Windows execution and a live Claude Code session were not tested. Hosted CI has not completed successfully for these fork heads; maintainer approval or reruns remain outstanding.
Validation used Python 3.12/3.14 and Node 26 on macOS arm64 as applicable. Earlier validation counts above are historical. Individual and combined counts overlap and should not be added.