Repository navigation
fix(broker): do not signal stale persisted pids - #749
Open
sylvesterkaczmarek wants to merge 1 commit into
Open
sylvesterkaczmarek wants to merge 1 commit into
sylvesterkaczmarek wants to merge 1 commit into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Author
|
Following up after the Group 6 maintenance pass. This branch is current, mergeable, and has no failing checks or unresolved review threads. Could a maintainer review it when convenient? |
sylvesterkaczmarek
force-pushed
the
fix/broker-pid-reuse
branch
from
October 1, 2026 09:08
9c854bc to
1e29da7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
broker.jsonas proof of process ownershipownedPidbefore teardown may signal a processensureBrokerSessioncall when startup failsFixes #743.
Validation
npm test(94/94 passed)npm run check-versiongit diff --checkMaintenance validation on 7 November 2026
The complete standalone branch suite passed 94 tests, including stale-PID ownership checks.
The four PRs merged without conflicts in a local checkout. All 109 tests passed, together with the version check and TypeScript build. The unchanged upstream checkout passed 91 tests and its build. Runtime tests used fake app-server fixtures and isolated test state, without live model requests or account credentials. Native Windows execution and a live Claude Code session were not tested. Hosted CI has not completed successfully for these fork heads; maintainer approval or reruns remain outstanding.
Validation used Python 3.12/3.14 and Node 26 on macOS arm64 as applicable. Earlier validation counts above are historical. Individual and combined counts overlap and should not be added.