Test suite is not hermetic inside a live Claude Code session: 4 failures at HEAD + fixture state leaks into the user's real plugin data dir #455

Symptom

Running npm test from a shell inside a live Claude Code session (the natural environment when Claude itself works on this repo):

1. 4 tests fail at HEAD with no code change:
   • status shows phases, hints, and the latest finished job
   • status preserves adversarial review kind labels
   • result returns the stored output for the latest finished job by default
   • resolveStateDir uses a temp-backed per-workspace directory
2. Fixture state silently pollutes the user's real plugin data. Two full-suite runs left ~150 fake codex-plugin-test-* workspace dirs and ~420 fake job records under $CLAUDE_PLUGIN_DATA/state/ — indistinguishable from real workspaces in the on-disk registry (fake jobs like "Investigate flaky test", "check failed auth" sit next to real project jobs).

The same suite passes 91/91 under env -i PATH=... HOME=... npm test.

Root cause — two inherited variables

• CLAUDE_PLUGIN_DATA: resolveStateDir honors it (lib/state.mjs), and a live session points it at the real data dir. Both in-process state writes in tests and spawned companions (buildEnv spreads process.env) then write fixture state there instead of the os.tmpdir() fallback — which is also exactly why the resolveStateDir fallback-path test fails.
• CODEX_COMPANION_SESSION_ID: set by the plugin's own session-lifecycle hook, inherited by the suite. filterJobsForCurrentSession then hides fixture-seeded jobs that carry no sessionId, so the status/result tests render empty output.

Note the second one is a test-visible instance of a runtime sharp edge: jobs without a matching sessionId are invisible to status even with --all (buildStatusSnapshot applies the session filter before options.all is consulted) — filed separately if useful.

Fix

PR incoming: pin CLAUDE_PLUGIN_DATA to a fresh temp root per test process in tests/helpers.mjs, clear CODEX_COMPANION_SESSION_ID there (session-scoped tests already compose it explicitly), and make the fallback-path state test manage the variable locally — mirroring what its CLAUDE_PLUGIN_DATA sibling test already does.

Validated in the reproducing environment (14 live CLAUDE*/CODEX* vars): 87/91 → 91/91, zero new entries in the real plugin state dir.

🤖 Generated with Claude Code