feat: open prompt in configured external editor by sayan-oai · Pull Request #7606 · openai/codex

sayan-oai · 2025-12-04T20:43:37Z

Add ctrl+g shortcut to enable opening current prompt in configured editor ($VISUAL or $EDITOR).

Prompt is updated with editor's content upon editor close.
Paste placeholders are automatically expanded when opening the external editor, and are not "recompressed" on close
- They could be preserved in the editor, but it would be hard to prevent the user from modifying the placeholder text directly, which would drop the mapping to the pending_paste value
Image placeholders stay as-is
ctrl+g explanation added to shortcuts menu, snapshot tests updated

Screen.Recording.2025-12-04.at.12.41.42.PM.mov

github-actions · 2025-12-04T20:43:45Z

All contributors have signed the CLA ✍️ ✅
_{Posted by the CLA Assistant Lite bot.}

sayan-oai · 2025-12-04T20:44:11Z

I have read the CLA Document and I hereby sign the CLA

sayan-oai · 2025-12-04T20:45:37Z

@codex review this

chatgpt-codex-connector · 2025-12-04T20:56:34Z

Codex Review: Didn't find any major issues. Chef's kiss.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

etraut-openai · 2025-12-04T21:32:48Z

@sayan-oai, looks like there are a few lint (cargo clippy) errors to fix.

codex-rs/tui/src/editor.rs

codex-rs/tui/src/app.rs

codex-rs/tui/src/bottom_pane/chat_composer.rs

sayan-oai · 2025-12-05T19:14:21Z

@codex review this

chatgpt-codex-connector · 2025-12-05T19:18:59Z

Codex Review: Didn't find any major issues. Breezy!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

hasan-ozdemir · 2025-12-06T22:46:52Z

Dear Participants; i have also implemented "ctrl+e:edit prompt in external editor" feature on windows since i was not aware of the improvement on this issue yet.
Now, it can open default notepad on windows.
Then how do i bring up my implementation in my topic branch so that you can check for the potential integration option into your solution if you like?
BTW: i have implemented it as a modular .JS extension along with an extension host on Rust TUI side.

codex-rs/tui/src/bottom_pane/chat_composer.rs

codex-rs/tui/src/app.rs

sayan-oai · 2025-12-09T16:25:54Z

@codex review this

chatgpt-codex-connector · 2025-12-09T16:32:42Z

Codex Review: Didn't find any major issues. Another round soon, please!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

sayan-oai · 2025-12-10T08:16:02Z

@codex review this

chatgpt-codex-connector · 2025-12-10T08:23:39Z

Codex Review: Didn't find any major issues. Can't wait for the next one!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

sayan-oai · 2025-12-17T01:19:33Z

@codex review this

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/tui/src/external_editor.rs

codex-rs/tui/src/lib.rs

codex-rs/tui/src/app.rs

sayan-oai · 2025-12-19T05:10:14Z

@codex review this

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/tui/src/external_editor.rs

nornagon-openai

Thanks for your patience and attention to detail, this is looking good! Some minor comments below but otherwise good to merge.

One minor thing for a followup: for non-terminal editors (e.g. code --wait), it would be nice to be able to cancel waiting for the editor to quit, in case it got stuck somehow. I'm not totally sure if this is possible to do given we're pausing the terminal event stream, but maybe we could still watch for ^C or something?

codex-rs/tui/src/app.rs

codex-rs/tui/src/tui.rs

windows doesnt allow saving files directly while another process has a handle, so rework editor logic to keep a temppath rather than the handle itself. this keeps windows happy and works with mac/linux

sayan-oai · 2025-12-20T02:39:59Z

@nornagon-openai Thanks, I appreciate your detailed reviews.

for non-terminal editors (e.g. code --wait), it would be nice to be able to cancel waiting for the editor to quit, in case it got stuck somehow. I'm not totally sure if this is possible to do given we're pausing the terminal event stream, but maybe we could still watch for ^C or something?

The two approaches that come to mind initially both have problems:

Spawn another process that listens for Ctrl+C on stdin (or its equivalent in raw mode since we keep that on), and wait until editor closes OR we read Ctrl+C from stdin.
- But, I think this would steal keystrokes from terminal editors (vim, nano) as they also read stdin
Handle SIGINT
- This would require us to leave raw mode, which would reintroduce the need for cursor gymnastics to clear potential input typed while the external editor is open.

Happy to consider other alternatives, and I will get opinions from others internally.

github-actions bot added a commit that referenced this pull request Dec 4, 2025

@sayan-oai has signed the CLA in #7606

82a4868

sayan-oai marked this pull request as draft December 4, 2025 21:35

nornagon-openai reviewed Dec 4, 2025

View reviewed changes

sayan-oai marked this pull request as ready for review December 5, 2025 07:34

sayan-oai requested a review from nornagon-openai December 5, 2025 07:34

nornagon-openai requested changes Dec 8, 2025

View reviewed changes

codex-rs/tui/src/bottom_pane/chat_composer.rs Outdated Show resolved Hide resolved

codex-rs/tui/src/app.rs Outdated Show resolved Hide resolved

sayan-oai requested a review from nornagon-openai December 9, 2025 05:56

sayan-oai force-pushed the dev/sayan/prompt-editor branch from 8499e00 to a32377c Compare December 12, 2025 19:45

jmpaz mentioned this pull request Dec 13, 2025

vi editing mode #2387

Closed

sayan-oai force-pushed the dev/sayan/prompt-editor branch from a32377c to 3cb00b6 Compare December 16, 2025 19:11

chatgpt-codex-connector bot reviewed Dec 17, 2025

View reviewed changes

codex-rs/tui/src/external_editor.rs Show resolved Hide resolved

sayan-oai force-pushed the dev/sayan/prompt-editor branch from f83dadc to a6376c9 Compare December 17, 2025 03:02

nornagon-openai reviewed Dec 18, 2025

View reviewed changes

codex-rs/tui/src/lib.rs Outdated Show resolved Hide resolved

codex-rs/tui/src/app.rs Outdated Show resolved Hide resolved

codex-rs/tui/src/app.rs Outdated Show resolved Hide resolved

codex-rs/tui/src/app.rs Outdated Show resolved Hide resolved

sayan-oai added 4 commits December 18, 2025 18:56

enable opening prompt in /

be557b2

expand pending_pastes when opening editor

a52486b

add shortcut to footer and improve errors

7ac9bce

gate import to unix

8791b43

sayan-oai added 17 commits December 18, 2025 18:56

simplify errors, rm Option, disambiguate image placeholders

acf929b

add external editor footer

c8e45e9

comment + clean up

2c46e32

mv const to correct area

e77f2a9

prevent shortcut while bottom pane in use

267e626

fix leaky map; compute image placeholders on demand

60e4892

fix terminal flushing

db5e8ae

fix footer end calculation

85934a7

whitespace

0871623

rework to set app state and avoid forced renders/cursor moves

b8c6ce2

keep raw mode enabled

a311b54

rm cursor moving + clearing logic bc we stay in raw mode

ea3b60f

clean up tests

841e8ac

cleanup

2037863

cleanup

ce38e84

cleanup + reorganize

a9aa090

refactor terminal release + regain to single operation

eb7ca03

sayan-oai force-pushed the dev/sayan/prompt-editor branch from a6376c9 to eb7ca03 Compare December 19, 2025 05:09

chatgpt-codex-connector bot reviewed Dec 19, 2025

View reviewed changes

codex-rs/tui/src/external_editor.rs Outdated Show resolved Hide resolved

nornagon-openai approved these changes Dec 19, 2025

View reviewed changes

codex-rs/tui/src/app.rs Outdated Show resolved Hide resolved

codex-rs/tui/src/app.rs Outdated Show resolved Hide resolved

codex-rs/tui/src/tui.rs Outdated Show resolved Hide resolved

codex-rs/tui/src/tui.rs Outdated Show resolved Hide resolved

sayan-oai added 2 commits December 19, 2025 10:12

rework opening editor to release filehandle

52fce07

windows doesnt allow saving files directly while another process has a handle, so rework editor logic to keep a temppath rather than the handle itself. this keeps windows happy and works with mac/linux

cleanup

eaabc7d

sayan-oai added 3 commits December 22, 2025 10:35

handle editors on windows

ae6ba42

use winsplit for windows parsing

cc0cdb3

Merge branch 'main' into dev/sayan/prompt-editor

b17fbd5

sayan-oai merged commit 4673090 into main Dec 22, 2025
26 checks passed

sayan-oai deleted the dev/sayan/prompt-editor branch December 22, 2025 23:12

github-actions bot locked and limited conversation to collaborators Dec 22, 2025

Comments

Conversation

sayan-oai commented Dec 4, 2025

Uh oh!

github-actions bot commented Dec 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sayan-oai commented Dec 4, 2025

Uh oh!

sayan-oai commented Dec 4, 2025

Uh oh!

chatgpt-codex-connector bot commented Dec 4, 2025

Uh oh!

etraut-openai commented Dec 4, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sayan-oai commented Dec 5, 2025

Uh oh!

chatgpt-codex-connector bot commented Dec 5, 2025

Uh oh!

hasan-ozdemir commented Dec 6, 2025

Uh oh!

Uh oh!

Uh oh!

sayan-oai commented Dec 9, 2025

Uh oh!

chatgpt-codex-connector bot commented Dec 9, 2025

Uh oh!

sayan-oai commented Dec 10, 2025

Uh oh!

chatgpt-codex-connector bot commented Dec 10, 2025

Uh oh!

sayan-oai commented Dec 17, 2025

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sayan-oai commented Dec 19, 2025

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

nornagon-openai left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sayan-oai commented Dec 20, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

github-actions bot commented Dec 4, 2025 •

edited

Loading