Skip to content

Expose original error details to turn lifecycle contributors - #49138

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/6f2058992126da0f69508ef51998e7581557deea
Sep 29, 2026
Merged

Expose original error details to turn lifecycle contributors#49138
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/6f2058992126da0f69508ef51998e7581557deea

Conversation

@copyberry

@copyberry copyberry Bot commented Sep 29, 2026 •
edited
Loading

Copy link
Copy Markdown

Expose original error details to turn lifecycle contributors

Why

Turn error hooks receive only a CodexErrorInfo category, which omits backend metadata such as usage-limit reset times and rate-limit snapshots.

What changed

Add borrowed CodexErrorDetails to TurnErrorInput and pass the original details through turn and compaction error notifications, alongside the existing error category.

Testing

Add coverage for usage-limit metadata during sampling, manual compaction, and post-turn compaction, including preservation of completed answers and existing error events. Extend lifecycle tests to verify that an InvalidImageRequest retains its details when surfaced as BadRequest.

@bryanashley copyberry
Expose original error details to turn lifecycle contributors (#49138)
f53f5a6 
## Why

Turn error hooks receive only a `CodexErrorInfo` category, which omits backend metadata such as usage-limit reset times and rate-limit snapshots.

## What changed

Add borrowed `CodexErrorDetails` to `TurnErrorInput` and pass the original details through turn and compaction error notifications, alongside the existing error category.

## Testing

Add coverage for usage-limit metadata during sampling, manual compaction, and post-turn compaction, including preservation of completed answers and existing error events. Extend lifecycle tests to verify that an `InvalidImageRequest` retains its details when surfaced as `BadRequest`.

GitOrigin-RevId: 6f2058992126da0f69508ef51998e7581557deea
@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/6f2058992126da0f69508ef51998e7581557deea branch from 03173f3 to f53f5a6 Compare September 29, 2026 02:41
@copyberry
copyberry Bot merged commit f53f5a6 into main Sep 29, 2026
1 check passed
@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/6f2058992126da0f69508ef51998e7581557deea branch September 29, 2026 02:41
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 29, 2026

This branch was previously deployed

1 inactive deployment
issue-triage — f53f5a6f Deployed Sep 29, 2026 by Baozi9 via Identify potential duplicates (open issues fallback) #49613
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@W-guofeng @Baozi9 @m-szymanska @indrolend @zhumengting01 @bryanashley