Repository navigation
Surface realtime voice catalog failures in the TUI - #49073
Merged
copyberry[bot] merged 1 commit intoSep 28, 2026
Merged
copyberry[bot] merged 1 commit into
copyberry[bot] merged 1 commit into
Conversation
## Why Failed `thread/realtime/listVoices` requests silently fell back to the built-in catalog, allowing voice selection and conversation startup to proceed without the server's voice catalog. ## What changed - Propagate catalog errors and show an error instead of opening the voice picker or starting a realtime conversation. - If the catalog lookup fails after saving a preference, report that the preference was saved but the effective voice could not be confirmed. Leave the in-memory voice settings unchanged. ## Testing Extend remote voice tests and snapshots to cover catalog failures when opening the picker, saving a preference, and starting a conversation. Verify that the preference is persisted, in-memory settings stay unchanged, and failed startup clears realtime state without sending `thread/realtime/start`. GitOrigin-RevId: ba40800d6f9002e02e2b33de8dc858188c3cddd7
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/ba40800d6f9002e02e2b33de8dc858188c3cddd7
branch
from
September 28, 2026 20:34
1b76f84 to
15c08be
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/ba40800d6f9002e02e2b33de8dc858188c3cddd7
branch
September 28, 2026 20:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Surface realtime voice catalog failures in the TUI
Why
Failed
thread/realtime/listVoicesrequests silently fell back to the built-in catalog, allowing voice selection and conversation startup to proceed without the server's voice catalog.What changed
Testing
Extend remote voice tests and snapshots to cover catalog failures when opening the picker, saving a preference, and starting a conversation. Verify that the preference is persisted, in-memory settings stay unchanged, and failed startup clears realtime state without sending
thread/realtime/start.