Repository navigation
Avoid SQLite stalls from connection setup and stderr span logging - #49032
Merged
copyberry[bot] merged 1 commit intoSep 28, 2026
Conversation
…9032) ## Why Setting `auto_vacuum` on every connection can wait for a writer lock even when the mode is unchanged. Logging every span entry and exit can also block SQLx workers on undrained stderr while they hold a write transaction. ## What changed - Set incremental vacuum only for empty databases or databases using full auto-vacuum, before enabling WAL. Preserve existing nonempty databases with auto-vacuum disabled. - Emit span creation and closure events in app-server text and JSON stderr logs, preserving busy/idle timings and explicit events while omitting span entry and exit records. ## Testing Add regression tests for opening and expanding writable pools while another connection holds a writer lock, and for transaction completion with undrained stderr in both log formats. Verify vacuum modes and retained log diagnostics. GitOrigin-RevId: 40d4ef32c7efc49f4240b987277ba45551259335
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/40d4ef32c7efc49f4240b987277ba45551259335
branch
from
September 28, 2026 17:00
01d20a8 to
46fdd5e
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/40d4ef32c7efc49f4240b987277ba45551259335
branch
September 28, 2026 17:01
jgold2-stripe
temporarily deployed
to
issue-triage
September 28, 2026 17:02 — with
GitHub Actions
Inactive
jgold2-stripe
temporarily deployed
to
issue-triage
September 28, 2026 17:02 — with
GitHub Actions
Inactive
jgold2-stripe
temporarily deployed
to
issue-triage
September 28, 2026 17:02 — with
GitHub Actions
Inactive
jgold2-stripe
temporarily deployed
to
issue-triage
September 28, 2026 17:03 — with
GitHub Actions
Inactive
omerliga
temporarily deployed
to
issue-triage
September 28, 2026 17:06 — with
GitHub Actions
Inactive
omerliga
temporarily deployed
to
issue-triage
September 28, 2026 17:06 — with
GitHub Actions
Inactive
omerliga
temporarily deployed
to
issue-triage
September 28, 2026 17:06 — with
GitHub Actions
Inactive
SELLISON97
temporarily deployed
to
issue-triage
September 28, 2026 17:08 — with
GitHub Actions
Inactive
SELLISON97
temporarily deployed
to
issue-triage
September 28, 2026 17:08 — with
GitHub Actions
Inactive
SELLISON97
temporarily deployed
to
issue-triage
September 28, 2026 17:08 — with
GitHub Actions
Inactive
SELLISON97
temporarily deployed
to
issue-triage
September 28, 2026 17:09 — with
GitHub Actions
Inactive
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid SQLite stalls from connection setup and stderr span logging
Why
Setting
auto_vacuumon every connection can wait for a writer lock even when the mode is unchanged. Logging every span entry and exit can also block SQLx workers on undrained stderr while they hold a write transaction.What changed
Testing
Add regression tests for opening and expanding writable pools while another connection holds a writer lock, and for transaction completion with undrained stderr in both log formats. Verify vacuum modes and retained log diagnostics.