Custom /prompts by dedrisian-oai · Pull Request #2696 · openai/codex

dedrisian-oai · 2025-08-26T01:23:07Z

Adds custom /prompts to ~/.codex/prompts/<command>.md.

Details:

Adds Op::ListCustomPrompts to core.
Returns ListCustomPromptsResponse with list of CustomPrompt (name, content).
TUI calls the operation on load, and populates the custom prompts (excluding prompts that collide with builtins).
Selecting the custom prompt automatically sends the prompt to the agent.

This reverts commit 0174e73.

Copilot

Pull Request Overview

This PR implements custom prompts functionality that allows users to save frequently used prompts as Markdown files in ~/.codex/prompts/ and access them through the TUI slash command interface.

Adds discovery and loading of custom prompts from the filesystem
Integrates custom prompts into the TUI slash command popup alongside built-in commands
Automatically submits prompt content when selected, excluding prompts that collide with built-in command names

Reviewed Changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
`codex-rs/protocol/src/custom_prompts.rs`	Defines `CustomPrompt` struct for representing custom prompts
`codex-rs/protocol/src/protocol.rs`	Adds `ListCustomPrompts` operation and response event types
`codex-rs/core/src/custom_prompts.rs`	Implements prompt file discovery logic with exclusion support
`codex-rs/core/src/codex.rs`	Handles `ListCustomPrompts` operation by discovering and returning prompts
`codex-rs/tui/src/bottom_pane/command_popup.rs`	Extends popup to display both built-in commands and custom prompts
`codex-rs/tui/src/bottom_pane/chat_composer.rs`	Handles selection of custom prompts and submission of their content
`codex-rs/tui/src/chatwidget.rs`	Requests custom prompts on session start and forwards to UI
`codex-rs/README.md`	Documents custom prompts feature and usage instructions

Comments suppressed due to low confidence (1)

codex-rs/tui/src/bottom_pane/command_popup.rs:1

The cursor positioning logic on line 396 is moved outside the match statement but only applies when the textarea text is set inside the match branches. This could lead to unexpected cursor behavior when the textarea is already non-empty but no text was set. Move the cursor positioning inside each match branch after setting the text.

use ratatui::buffer::Buffer;

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

dedrisian-oai · 2025-08-26T16:25:39Z

@codex

chatgpt-codex-connector · 2025-08-26T16:37:22Z

Summary

Moved the slash command tab-completion cursor update into each match branch so the cursor only moves to the end after the textarea text is changed for built-in commands or custom promptscodex-rs/tui/src/bottom_pane/chat_composer.rsL376-L394

Testing

❌ cargo test -p codex-tui (diff_render snapshot tests failed)

View task →

github-actions · 2025-08-26T16:43:23Z

Summary
Adds “Custom Prompts” support: discovers ~/.codex/prompts/*.md, exposes via protocol (Op::ListCustomPrompts + response), and integrates into the TUI slash popup with tests and README docs.

Review
Nice feature cut with clean protocol/core/TUI threading and good tests. A few small nits to tighten behavior and UX:

codex-rs/core/src/custom_prompts.rs (new file): Consider using a cross‑platform home resolver (e.g., dirs crate) in default_prompts_dir() to avoid relying on HOME on non‑Unix systems.
codex-rs/core/src/codex.rs (@@ -1279,+): The spawn_blocking(...).await.unwrap_or_default() swallows discovery errors; consider logging the join/error cause so failures aren’t silent.
codex-rs/tui/src/bottom_pane/chat_composer.rs (@@ -372,7 +376,18): You removed set_cursor(...) after inserting the slash text. Confirm the caret ends at the line end; if not, re-add setting the cursor to self.textarea.text().len().
codex-rs/tui/src/bottom_pane/command_popup.rs (multiple hunks): CommandItem::Prompt(usize) indexes into prompts. If prompts can refresh while the popup is open, ensure selection remains consistent; otherwise consider referencing by name to decouple from indices.
codex-rs/tui/src/bottom_pane/command_popup.rs (@@ -126,5 +179,13): Label “send saved prompt” reads fine; if you standardize descriptions elsewhere, align casing/tense as needed.

Follow-up (outside this PR scope)

Run TUI snapshot tests and accept updates if expected: cargo test -p codex-tui, then cargo insta pending-snapshots -p codex-tui.

View workflow run

dedrisian-oai · 2025-08-28T21:12:53Z

some tests are now failing because of a different PR merged before this, hold on a sec while I fix

bolinfest · 2025-08-28T21:51:59Z

+                        name: format!("/{}", self.prompts[i].name),
+                        match_indices: indices.map(|v| v.into_iter().map(|i| i + 1).collect()),
+                        is_current: false,
+                        description: Some("send saved prompt".to_string()),


Why don't we take the first line of the prompt?

I think that might look weird if a prompt has just one word in the first line. The "send saved prompt" at least tells the user what happens if they hit enter. But either way works, lmk which you'd prefer!

We can try it this way and change it if it doesn't feel right, I guess.

easong-openai · 2025-08-29T01:43:27Z

@codex do a deep review

chatgpt-codex-connector

Codex Review: Here are some suggestions.

Reply with @codex fix comments to fix any unresolved comments.

About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".

bolinfest · 2025-08-29T01:56:15Z

+                        name: format!("/{}", self.prompts[i].name),
+                        match_indices: indices.map(|v| v.into_iter().map(|i| i + 1).collect()),
+                        is_current: false,
+                        description: Some("send saved prompt".to_string()),


We can try it this way and change it if it doesn't feel right, I guess.

dedrisian-oai added 12 commits August 25, 2025 17:53

/addprompt

0174e73

Add /prompts folder

56db775

Revert "/addprompt"

1a5c12c

This reverts commit 0174e73.

Tests

6714afe

Wip shift to core

a2985ba

fix

0ac35f8

fix

85bcd57

readme

ba05216

fixes

4d7bb51

add another test

c70e1fc

only .md files

5273034

rm

d5485d7

dedrisian-oai requested a review from Copilot August 26, 2025 15:33

Copilot AI reviewed Aug 26, 2025

View reviewed changes

dedrisian-oai added 2 commits August 26, 2025 08:39

change tempdir

b7e37c9

Merge branch 'main' into daniel/prompts

0cc82ec

dedrisian-oai marked this pull request as ready for review August 26, 2025 15:39

dedrisian-oai marked this pull request as draft August 26, 2025 16:39

dedrisian-oai marked this pull request as ready for review August 26, 2025 16:39

dedrisian-oai added the code-review Issues relating to code reviews performed by codex label Aug 26, 2025

github-actions Bot added codex-review-in-progress and removed code-review Issues relating to code reviews performed by codex labels Aug 26, 2025

github-actions Bot added codex-review-completed and removed codex-review-in-progress labels Aug 26, 2025

dedrisian-oai marked this pull request as draft August 26, 2025 16:53

Use $CODEX_HOME instead

0645782

dedrisian-oai marked this pull request as ready for review August 26, 2025 17:05

dedrisian-oai requested review from bolinfest and easong-openai August 26, 2025 17:06

Merge branch 'main' into daniel/prompts

9e1cf6e

easong-openai approved these changes Aug 28, 2025

View reviewed changes

dedrisian-oai added 2 commits August 28, 2025 13:52

Merge branch 'main' into daniel/prompts

bc729bb

Fix merge conflicts

5ea885e

dedrisian-oai added 2 commits August 28, 2025 14:25

Fix paste burst issue

7c49116

fix

ac90466

bolinfest requested changes Aug 28, 2025

View reviewed changes

bolinview

8148fcb

chatgpt-codex-connector Bot reviewed Aug 29, 2025

View reviewed changes

Comment thread codex-rs/core/src/custom_prompts.rs Resolved

mv prompts.md

7ecd5af

bolinfest approved these changes Aug 29, 2025

View reviewed changes

dedrisian-oai added 3 commits August 28, 2025 19:01

string->pathbuf

dcdbf04

fix

cfae048

skip unreadable files

b63ff09

dedrisian-oai enabled auto-merge (squash) August 29, 2025 02:15

dedrisian-oai merged commit b8e8454 into main Aug 29, 2025

dedrisian-oai deleted the daniel/prompts branch August 29, 2025 02:16

github-actions Bot locked and limited conversation to collaborators Aug 29, 2025

Conversation

dedrisian-oai commented Aug 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

dedrisian-oai commented Aug 26, 2025

Uh oh!

chatgpt-codex-connector Bot commented Aug 26, 2025

Uh oh!

github-actions Bot commented Aug 26, 2025

Uh oh!

dedrisian-oai commented Aug 28, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bolinfest Aug 28, 2025

Choose a reason for hiding this comment

Uh oh!

dedrisian-oai Aug 28, 2025

Choose a reason for hiding this comment

Uh oh!

bolinfest Aug 29, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

easong-openai commented Aug 29, 2025

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

bolinfest Aug 29, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

dedrisian-oai commented Aug 26, 2025 •

edited

Loading