Repository navigation
Conversation
💡 Codex Reviewcodex/codex-rs/tui/src/app_server_session.rs Lines 1414 to 1417 in 11f94d4  Preserve server sandbox fallback when permissionProfile is absent
When ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Closing this pull request because it has had no updates for more than 14 days. If you plan to continue working on it, feel free to reopen or open a new PR. |
Why
The core
Opturn-context path should not carry both the new permissions model and the legacySandboxPolicymodel. Earlier PRs made user turns permission-profile-first; this follows through for turn-context updates so the session layer only seesPermissionProfileplus explicit active-profile provenance.The app-server v2 boundary still accepts the legacy
sandboxPolicyoverride for now. This PR keeps that API behavior by converting the legacy override into a concretePermissionProfilebefore submitting the core op, then marks the active profile identity as cleared because a raw sandbox override is not a named profile selection.What Changed
sandbox_policyfromOp::UserInputWithTurnContextandOp::OverrideTurnContext.clear_active_permission_profileto those ops so callers can explicitly clear profile name/provenance when they submit a concrete permission profile derived from a legacy sandbox override.core/src/session/handlers.rsand into the app-server request handling boundary.AppCommandprofile-only for normal TUI commands while preserving unknown clear-provenance ops asOtherinstead of losing the clear signal.Verification
cargo check -p codex-protocol -p codex-core -p codex-tui -p codex-app-server --testscargo check -p codex-memories-write --testscargo test -p codex-core override_turn_contextjust fix -p codex-protocoljust fix -p codex-corejust fix -p codex-tuijust fix -p codex-app-serverjust fix -p codex-memories-writeStack created with Sapling. Best reviewed with ReviewStack.