Repository navigation
Conversation
💡 Codex Reviewcodex/codex-rs/tui/src/app_server_session.rs Lines 1414 to 1417 in b42ea0a  Restore sandbox fallback when permissionProfile is missing
When ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Closing this pull request because it has had no updates for more than 14 days. If you plan to continue working on it, feel free to reopen or open a new PR. |
Why
Op::UserTurnis the explicit turn submission path where callers already provide the complete turn context. Keepingpermission_profileoptional meant core still had to preserve a legacySandboxPolicyfallback for this path, even though every migrated caller should know the canonical permissions profile at submission time.This PR makes
permission_profilerequired forUserTurnso core no longer has to derive command permissions from the legacy sandbox field for explicit turns. The legacysandbox_policyslot is left in place temporarily but is ignored forUserTurn; follow-up PRs can remove it once the remaining mechanical test/helper callsites stop carrying it.What Changed
Op::UserTurn.permission_profilefromOption<PermissionProfile>to requiredPermissionProfile.UserInputWithTurnContextandOverrideTurnContextlegacy fallback behavior unchanged because those are still compatibility update surfaces.Verification
cargo check -p codex-protocol -p codex-core -p codex-tui --testsStack created with Sapling. Best reviewed with ReviewStack.