Repository navigation
Conversation
💡 Codex Reviewcodex/codex-rs/tui/src/app_server_session.rs Lines 1414 to 1417 in 2e8a66d  Preserve remote thread permissions when profile is omitted
When ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Closing this pull request because it has had no updates for more than 14 days. If you plan to continue working on it, feel free to reopen or open a new PR. |
Why
TurnContextalready carries the canonicalPermissionProfilefor a turn. Keeping aTurnContext::sandbox_policy()convenience method made it easy for production code to re-project that profile into the legacySandboxPolicyshape even when the caller did not actually need a legacy boundary payload.This change keeps legacy projection explicit: new turn telemetry records the canonical profile, while tests that intentionally construct old rollout records build the compatibility
sandbox_policylocally as a fixture detail.What Changed
TurnContext::sandbox_policy()from the core session turn context.sandbox_policytopermission_profileso feedback captures the canonical permission model instead of a lossy compatibility projection.TurnContextItemwithpermission_profile: Noneand a legacysandbox_policy.Verification
cd codex-rs && cargo check -p codex-core --testscd codex-rs && just fix -p codex-coreStack created with Sapling. Best reviewed with ReviewStack.