Repository navigation
Conversation
💡 Codex Reviewcodex/codex-rs/tui/src/app_server_session.rs Lines 1414 to 1417 in 4a90f76  Restore sandbox fallback when permissionProfile is missing
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Closing this pull request because it has had no updates for more than 14 days. If you plan to continue working on it, feel free to reopen or open a new PR. |
Summary
Removes the legacy
sandboxPolicyfield from MCP sandbox-state metadata.MCP servers that opt into
codex/sandbox-state-metanow receive the canonicalpermissionProfileplus the existing sandbox cwd, Linux sandbox path, and Landlock flag. The duplicated legacy compatibility projection is no longer serialized inSandboxState.Why
SandboxStatealready includedpermissionProfile, and the legacysandboxPolicyprojection is lossy for profiles with richer file-system rules. This keeps MCP metadata aligned with the permission-profile migration and removesSandboxPolicyusage fromcodex-rs/codex-mcp/src.Verification
just fmtcargo test -p codex-mcpcargo test -p codex-core --test all --no-runjust fix -p codex-mcp -p codex-coreI also tried
cargo test -p codex-core stdio_mcp_tool_call_includes_sandbox_state_meta; the direct Cargo run failed before exercising the assertion because it could not locate thetest_stdio_serverhelper binary. CI/Bazel provides that runfile setup.Stack created with Sapling. Best reviewed with ReviewStack.