Repository navigation
Conversation
💡 Codex Reviewcodex/codex-rs/tui/src/app_server_session.rs Line 1417 in 513a439  Recover profile from sandbox when permissionProfile missing
When ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Closing this pull request because it has had no updates for more than 14 days. If you plan to continue working on it, feel free to reopen or open a new PR. |
Summary
Removes the legacy
sandbox_policyfield from the thread-store domain model.StoredThreadsummaries no longer parse, carry, or re-serializeSandboxPolicy; the field was only being populated from legacy metadata defaults and was not read by production callers. The remote thread-store proto field remains in place as an ignored wire-compatibility field, but the Rust domain object stops exposing it.Why
Thread metadata persistence still stores a legacy sandbox projection for older readers, but thread-store consumers should not treat that projection as canonical permission state. Removing it from
StoredThreadavoids carrying stale or lossySandboxPolicyvalues through list/read paths while the migration continues aroundPermissionProfile.This also reduces
SandboxPolicyusage to zero undercodex-rs/thread-store/src.Verification
just fmtcargo test -p codex-thread-storecargo test -p codex-core realtime_contextcargo test -p codex-app-server summary_from_stored_thread_preserves_millisecond_precisionjust fix -p codex-thread-store -p codex-core -p codex-app-serverStack created with Sapling. Best reviewed with ReviewStack.