Repository navigation
Conversation
💡 Codex Reviewcodex/codex-rs/utils/sandbox-summary/src/sandbox_summary.rs Lines 39 to 40 in 0fc2a7b  Classify bridged-incompatible root writes as custom permissions
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Closing this pull request because it has had no updates for more than 14 days. If you plan to continue working on it, feel free to reopen or open a new PR. |
Why
core/tests/common/test_codex.rsstill exposedsubmit_turn_with_policy()helpers that convertedSandboxPolicyintoPermissionProfilebefore submitting turns. The websocket tests were the remaining callers, so they could exercise the same behavior directly through permission profiles.Removing these helpers keeps new tests from accidentally reaching for the legacy sandbox abstraction when submitting
Op::UserTurn.What Changed
submit_turn_with_permission_profile()with the active test config permissions.submit_turn_with_policy(),submit_turn_with_policies(), andsubmit_with_policy()from the sharedTestCodexhelpers.sandbox_policyfield from aPermissionProfilefor directOp::UserTurnconstruction.Verification
cargo test -p codex-core websocket_first_turn_uses_startup_prewarm_and_create -- --nocapturejust fix -p codex-coreStack created with Sapling. Best reviewed with ReviewStack.