Skip to content

analytics: distinguish custom managed permission profiles - #20363

Closed
bolinfest wants to merge 1 commit into
pr20362from
pr20363
Closed

analytics: distinguish custom managed permission profiles#20363
bolinfest wants to merge 1 commit into
pr20362from
pr20363

Conversation

@bolinfest

@bolinfest bolinfest commented Apr 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Why

Analytics still collapsed a managed permission profile with unrestricted filesystem access and restricted network access into the external_sandbox telemetry bucket. That loses the same distinction this stack is trying to preserve elsewhere: external sandbox means enforcement is delegated outside Codex, while managed custom permissions are still represented by Codex's PermissionProfile model.

What Changed

  • Updated the analytics sandbox_policy classifier to report custom_permissions for managed unrestricted-filesystem/restricted-network profiles.
  • Updated the reducer test to capture that distinction explicitly.
  • Replaced a read-only analytics test fixture that still built a PermissionProfile through SandboxPolicy with PermissionProfile::read_only().

Verification

  • cargo test -p codex-analytics managed_full_disk_with_restricted_network_reports_custom_permissions

Stack created with Sapling. Best reviewed with ReviewStack.

@bolinfest
bolinfest requested a review from a team as a code owner April 30, 2026 09:09
@bolinfest
bolinfest changed the base branch from main to pr20362 April 30, 2026 09:09
This was referenced Apr 30, 2026
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Apr 30, 2026

Copy link
Copy Markdown
Contributor

💡 Codex Review

codex/codex-rs/utils/sandbox-summary/src/sandbox_summary.rs

Lines 40 to 46 in a7333a9

let writable_entries = writable_roots
.iter()
.map(|root| writable_root_display(root.root.as_path(), cwd))
.collect::<Vec<_>>();
summary_with_network(
&format!("workspace-write [{}]", writable_entries.join(", ")),
network_enabled,

P2 Badge Treat non-workdir write-only profiles as custom

summarize_managed_profile now labels any managed profile with at least one writable root as workspace-write, but custom managed policies can have writable paths (for example /tmp or another absolute root) without granting write access to the working directory. In that case this branch produces a misleading mode string instead of custom permissions, which regresses the previous to_legacy_sandbox_policy-based behavior and can misstate the effective sandbox in user-facing status/config summaries.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

This was referenced Apr 30, 2026
Closed
Closed
Closed
Closed
Closed
This was referenced Apr 30, 2026
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Apr 30, 2026
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@github-actions

github-actions Bot commented May 16, 2026

Copy link
Copy Markdown
Contributor

Closing this pull request because it has had no updates for more than 14 days. If you plan to continue working on it, feel free to reopen or open a new PR.

@github-actions github-actions Bot closed this May 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@bolinfest