tui: always restore the terminal on early exit#15671
Merged
etraut-openai merged 1 commit intomainfrom Mar 24, 2026
Merged
Conversation
Contributor
|
@etraut-openai LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes early TUI exit paths that could leave the terminal in a dirty state and cause a stray
%prompt marker after the app quit.Root cause
Both
tuiandtui_app_serverhad early returns aftertui::init()that did not guarantee terminal restore. When that happened, shells likezshinherited the altered terminal state.Changes
run_ratatui_app()in bothtuiandtui_app_server