Thread guardian Responses API errors into denial rationale#15516
Merged
charley-oai merged 1 commit intomainfrom Mar 23, 2026
Merged
Thread guardian Responses API errors into denial rationale#15516charley-oai merged 1 commit intomainfrom
charley-oai merged 1 commit intomainfrom
Conversation
Surface the last Responses API error in the guardian rejection rationale when a review turn completes without an assessment payload. Add a regression test for the HTTP 400 path. Co-authored-by: Codex <[email protected]>
Contributor
Author
|
@codex review |
Contributor
|
Codex Review: Didn't find any major issues. 🚀 ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
dylan-hurd-oai
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EventMsg::Errorwhile waiting for review completion/responsesHTTP 400 pathTesting
just fmtcargo test -p codex-core guardian_review_surfaces_responses_api_errors_in_rejection_reasonjust argument-comment-lint -p codex-coreNotes
cargo test -p codex-corestill fails on the pre-existing unrelated testtools::js_repl::tests::js_repl_imported_local_files_can_access_repl_globalsin this environment (mktemp ... Operation not permittedwhile downloadingdotslash)