Conversation
|
Hi, this is a useful addition! It would be great to support disabling skills by folder as well. I did not see this documented, but using folders inside .codex/skills or .agents/skills appears to work, and it is helpful for organizing skills. |
|
@J3m5 Disabling skills by folder needs a bit more thought, since there are more states to manage. But the currently experimental plugin feature should solve your problem: you can organize the skills as a plugin and then enable or disable the entire plugin. We’ll share more developer docs on this later. |
5bbcdc8 to
5776801
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8d81ff9ce9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -531,7 +541,11 @@ impl PluginsManager { | |||
| return outcome; | |||
There was a problem hiding this comment.
Key plugin cache by effective skill rules
plugins_for_config_with_force_reload returns a single cached outcome for all configs. This change made plugin loading depend on config_layer_stack skill rules (including SessionFlags) to compute disabled_skill_paths/has_enabled_skills. After caching config A, config B with different skill overrides can get stale plugin capability data, causing incorrect plugin mentions/summaries.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
It is OK plugin doesn't rely on SessionFlags.
Support disabling skills by name, primarily for plugin skills. We can’t use the path, since plugin skill paths may change across versions.