Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 39ada667f7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| match sync_openai_plugins_repo_via_git(codex_home, git_binary) { | ||
| Ok(remote_sha) => Ok(remote_sha), | ||
| Err(GitCuratedRepoSyncError::GitUnavailable(err)) => { | ||
| warn!( | ||
| error = %err, | ||
| git_binary, | ||
| "git unavailable for curated plugin sync; falling back to GitHub HTTP" | ||
| ); | ||
| sync_openai_plugins_repo_via_http(codex_home, api_base_url) | ||
| } | ||
| Err(GitCuratedRepoSyncError::SyncFailed(err)) => Err(err), |
There was a problem hiding this comment.
Only GitUnavailable errors trigger HTTP fallback. Any other git failure (network/auth/timeout/non-zero exit) returns immediately, so curated sync now fails in environments where git is installed but unusable even though the HTTP path could succeed. This conflicts with the stated behavior of "start with git clone, fallback to http."
Useful? React with 👍 / 👎.
alexsong-oai
left a comment
alexsong-oai
left a comment
There was a problem hiding this comment.
wondering why git clone is preferred?
|
@alexsong-oai GitHub has rate limits for anonymous HTTP downloads. |
2 participants
start with git clone, fallback to http.