tui: queue follow-ups during manual /compact by charley-oai · Pull Request #15259 · openai/codex

charley-oai · 2026-03-20T01:23:15Z

Summary

queue input after the user submits /compact until that manual compact turn ends
mirror the same behavior in the app-server TUI
add regressions for input queued before compact starts and while it is running

charley-oai · 2026-03-20T01:33:38Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 00c5153692

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/tui/src/chatwidget.rs

codex-rs/tui_app_server/src/chatwidget.rs

charley-oai · 2026-03-20T05:37:48Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fd48bd7ffa

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/tui/src/chatwidget.rs

codex-rs/tui_app_server/src/chatwidget.rs

charley-oai · 2026-03-20T06:14:13Z

@codex review

chatgpt-codex-connector

💡 Codex Review

codex/codex-rs/tui/src/chatwidget.rs

Lines 5801 to 5802 in 3298da6

    
           if let Some(user_message) = self.queued_user_messages.pop_front() { 
        
               self.submit_user_message(user_message);

Skip autosend while manual compact gate is active

maybe_send_next_queued_input pops the front message even when /compact gating is active. submit_user_message then re-queues it at the back when manual_compact_turn_state.is_active() (lines 5014-5016), so each replayed completion can rotate the queue (A,B -> B,A). This can execute follow-up prompts out of order once compact finishes.

codex/codex-rs/tui_app_server/src/chatwidget.rs

Lines 6837 to 6838 in 3298da6

    
           if let Some(user_message) = self.queued_user_messages.pop_front() { 
        
               self.submit_user_message(user_message);

Prevent queue reordering during compact in app-server TUI

The app-server mirror has the same pattern: autosend pops from the front even while the manual compact gate is active, and submit_user_message re-adds to the back (lines 5162-5164). Replayed turn-complete events during compact can reorder queued follow-ups before they are finally sent.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

charley-oai · 2026-03-21T00:17:31Z

@codex review

codex-rs/tui/src/chatwidget.rs

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8fe99c945d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/tui/src/chatwidget.rs

charley-oai · 2026-03-21T00:32:02Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 599f9eb30b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/tui/src/chatwidget.rs

charley-oai · 2026-03-21T01:40:24Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: dd11c51456

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/tui/src/chatwidget.rs

codex-rs/tui_app_server/src/chatwidget.rs

charley-oai · 2026-03-21T05:40:30Z

@codex review

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f4749c6bea

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-03-21T05:45:26Z

codex-rs/tui_app_server/src/chatwidget.rs

+        self.rejected_steers_queue
+            .push_back(pending_steer.user_message);
+        self.refresh_pending_input_preview();
+        true


Auto-submit rejected steers after turn completion race

enqueue_rejected_steer only queues and redraws. If turn/steer is rejected after a turn/completed notification already cleared task_running, there is no subsequent completion callback to drain the queue, so the follow-up can remain stuck indefinitely. The core TUI path handles this by calling maybe_send_next_queued_input() when not running; this app-server mirror omits it.

Useful? React with 👍 / 👎.

not possible in app server

Co-authored-by: Codex <[email protected]>

chatgpt-codex-connector bot reviewed Mar 20, 2026

View reviewed changes

codex-rs/tui/src/chatwidget.rs Outdated Show resolved Hide resolved

codex-rs/tui_app_server/src/chatwidget.rs Outdated Show resolved Hide resolved

github-actions bot mentioned this pull request Mar 20, 2026

📊 Bản tin hàng ngày công cụ AI CLI 2026-03-20 compasify/agents-radar#60

Open

aibrahim-oai approved these changes Mar 20, 2026

View reviewed changes

chatgpt-codex-connector bot reviewed Mar 20, 2026

View reviewed changes

codex-rs/tui/src/chatwidget.rs Outdated Show resolved Hide resolved

codex-rs/tui_app_server/src/chatwidget.rs Outdated Show resolved Hide resolved

chatgpt-codex-connector bot reviewed Mar 20, 2026

View reviewed changes

charley-oai commented Mar 21, 2026

View reviewed changes

codex-rs/tui/src/chatwidget.rs Outdated Show resolved Hide resolved

chatgpt-codex-connector bot reviewed Mar 21, 2026

View reviewed changes

codex-rs/tui/src/chatwidget.rs Show resolved Hide resolved

chatgpt-codex-connector bot reviewed Mar 21, 2026

View reviewed changes

codex-rs/tui/src/chatwidget.rs Show resolved Hide resolved

chatgpt-codex-connector bot reviewed Mar 21, 2026

View reviewed changes

codex-rs/tui/src/chatwidget.rs Show resolved Hide resolved

codex-rs/tui_app_server/src/chatwidget.rs Show resolved Hide resolved

github-actions bot mentioned this pull request Mar 21, 2026

📊 Bản tin hàng ngày công cụ AI CLI 2026-03-21 compasify/agents-radar#65

Open

chatgpt-codex-connector bot reviewed Mar 21, 2026

View reviewed changes

charley-oai force-pushed the cc/queue-during-compact branch from f4749c6 to 362ab20 Compare March 23, 2026 00:47

This was referenced Mar 23, 2026

📊 AI CLI 工具社区动态日报 2026-03-23 gsscsd/big_model_radar#80

Open

📊 Bản tin hàng ngày công cụ AI CLI 2026-03-23 compasify/agents-radar#75

Open

steer: queue follow-ups for non-steerable turns

ff28c3b

Co-authored-by: Codex <[email protected]>

charley-oai force-pushed the cc/queue-during-compact branch from 7c18fec to ff28c3b Compare March 23, 2026 04:33

charley-oai merged commit e838645 into main Mar 23, 2026
32 of 36 checks passed

charley-oai deleted the cc/queue-during-compact branch March 23, 2026 17:19

github-actions bot locked and limited conversation to collaborators Mar 23, 2026

	if let Some(user_message) = self.queued_user_messages.pop_front() {
	self.submit_user_message(user_message);

Conversation

charley-oai commented Mar 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

charley-oai commented Mar 20, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

charley-oai commented Mar 20, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

charley-oai commented Mar 20, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

charley-oai commented Mar 21, 2026

Uh oh!

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

charley-oai commented Mar 21, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

charley-oai commented Mar 21, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

charley-oai commented Mar 21, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Mar 21, 2026

Choose a reason for hiding this comment

Uh oh!

charley-oai Mar 21, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

charley-oai commented Mar 20, 2026 •

edited

Loading