Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 326cc7459b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| run: | | ||
| set -euo pipefail | ||
|
|
||
| if gh release view "${RELEASE_TAG}" > /dev/null 2>&1; then |
There was a problem hiding this comment.
The publish-release job runs gh release view without a checkout and without --repo/GH_REPO. In this job there is no local git remote context, so gh can fail to resolve the target repository and abort before publishing. Pass --repo "${GITHUB_REPOSITORY}" (or set GH_REPO) for a deterministic release check.
Useful? React with 👍 / 👎.
cconger
force-pushed
the
v8-bazel-build
branch
2 times, most recently
from
16c0c54 to
d282cad
Compare
| v8_string( | ||
| name = "v8_enable_pointer_compression", | ||
| - default = "none", | ||
| + default = "False", |
There was a problem hiding this comment.
As pointed out in other PRs I would like to revisit this.
cconger
force-pushed
the
v8-bazel-build
branch
2 times, most recently
from
d099210 to
ec911b4
Compare
This is a new package that depends on rusty-v8 for embedding a v8 engine. This builds and works on non-musl platforms now because rusty-v8 provides versions for that. But we mocked out the loading of a musl built library. TODO: iterate on providing the musl built version for musl-linux builds. TODO: create a release workflow for publishing the artifact that rusty-v8 can link against
Remove codex-v8-poc from the release branch so CI can validate only the Bazel build and release machinery. Keep V8 version resolution working by falling back to MODULE.bazel when Cargo.lock no longer carries the v8 crate.
Drop doc comment. Assume buildbuddy always and common bazelci
2 participants
Alternative approach, we use rusty_v8 for all platforms that its predefined, but lets build from source a musl v8 version with bazel for x86 and aarch64 only. We would need to release this on github and then use the release.