fix: ensure sync modal only triggers if community sharing is enabled#21376
Merged
tjbck merged 1 commit intoopen-webui:devfrom Feb 13, 2026
Merged
fix: ensure sync modal only triggers if community sharing is enabled#21376tjbck merged 1 commit intoopen-webui:devfrom
tjbck merged 1 commit intoopen-webui:devfrom
Conversation
👋 Welcome and Thank You for Contributing!We appreciate you taking the time to submit a pull request to Open WebUI!
|
Contributor
|
Thanks! |
iccyuan
pushed a commit
to iccyuan/open-webui
that referenced
this pull request
Feb 14, 2026
hsmallbone
pushed a commit
to hsmallbone/open-webui
that referenced
this pull request
Feb 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Note to first-time contributors: Please open a discussion post in Discussions to discuss your idea/fix with the community before creating a pull request, and describe your changes before submitting a pull request.
This is to ensure large feature PRs are discussed with the community first, before starting work on it. If the community does not want this feature or it is not relevant for Open WebUI as a project, it can be identified in the discussion before working on the feature and submitting the PR.
Before submitting, make sure you've checked the following:
devbranch. PRs targetingmainwill be immediately closed.devto ensure no unrelated commits (e.g. frommain) are included. Push updates to the existing PR branch instead of closing and reopening.Changelog Entry
Description
Currently, when a user accesses the app with the
?sync=truequery parameter (e.g., via a community sharing link), the "Community Sharing" modal is queued to display regardless of whether the community sharing feature is enabled in the settings. This means that if the feature is disabled, the modal will unexpectedly appear as soon as the user enables the feature in the Admin Settings, even if they are in a completely different context.This PR fixes this behavior by adding a check to ensure that the "Community Sharing" feature (
enable_community_sharing) is actually enabled before setting the modal state totrueon mount. This prevents the modal from being queued when the feature is disabled.Changed
src/routes/+layout.svelteto check theenable_community_sharingfeature flag before showing the sync modal on mount.Fixed
?sync=true.Additional Information
The fix involves modifying the
onMountlogic insrc/routes/+layout.svelteto include an additional condition:&& ($config?.features?.enable_community_sharing ?? false).Contributor License Agreement
By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.
Note
Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.