fix: prevent RuntimeError in process_metadata when excluding keys#21105
Merged
tjbck merged 1 commit intoopen-webui:devfrom Feb 13, 2026
Merged
fix: prevent RuntimeError in process_metadata when excluding keys#21105tjbck merged 1 commit intoopen-webui:devfrom
tjbck merged 1 commit intoopen-webui:devfrom
Conversation
👋 Welcome and Thank You for Contributing!We appreciate you taking the time to submit a pull request to Open WebUI!
|
Contributor
|
Thanks! |
iccyuan
pushed a commit
to iccyuan/open-webui
that referenced
this pull request
Feb 14, 2026
hsmallbone
pushed a commit
to hsmallbone/open-webui
that referenced
this pull request
Feb 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed
process_metadatafunction that would raiseRuntimeError: dictionary changed size during iterationwhen metadata contained any of the excluded keys (content,pages,tables,paragraphs,sections,figures).The function was deleting keys while iterating over
dict.items(), which invalidates the iterator in Python 3. Now builds a new dict instead of mutating the original.Why this has never been reported
This bug has never surfaced in practice due to how the code paths are structured:
Multitenancy mode users - The multitenancy Milvus client (and others) doesn't call
process_metadataat all, passing metadata directly without processing.Standard mode users - Before metadata reaches
process_metadata, it passes throughfilter_metadatafirst (inprocess_file), which already removes the excluded keys. By the timeprocess_metadatais called, those keys are already gone.Document loaders - The custom loaders (MinerU, Mistral OCR, Datalab Marker, Docling, Tika) don't include these keys in their metadata output. Only certain LangChain loaders like
AzureAIDocumentIntelligenceLoadermight return them, but they get filtered upstream.Why it should still be fixed
Despite being unreachable in current code paths, this is a latent bug that could cause failures if:
process_metadatadirectly without prior filteringfilter_metadatacallFixing it ensures the function works correctly in isolation, as its signature and docstring imply it should.
Contributor License Agreement
By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.
Note
Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.