Skip to content

Comments

feat: Display error returned by ollama#203

Merged
tjbck merged 4 commits intoopen-webui:mainfrom
therohitdas:display-error
Dec 13, 2023
Merged

feat: Display error returned by ollama#203
tjbck merged 4 commits intoopen-webui:mainfrom
therohitdas:display-error

Conversation

@therohitdas
Copy link
Contributor

I tried checking if the response is okay and displaying an error if not for #193

I don't know how to work with svelte (or any framework) so I was not able to remove the loader.
Currently, this is all you see when Ollama returns an error:

Screenshot 2023-12-11 at 4 04 37 PM

The loader stays there after the toast disappears.
We can add an additional toast, for now, saying Please see ollama logs for more information or Refresh the page to try again.
After refreshing, there is a saved chat with no second message.
Example:
Screenshot 2023-12-11 at 4 12 51 PM

@therohitdas therohitdas marked this pull request as ready for review December 13, 2023 07:41
@tjbck tjbck linked an issue Dec 13, 2023 that may be closed by this pull request
@tjbck
Copy link
Contributor

tjbck commented Dec 13, 2023

LGTM, Thanks!

@tjbck tjbck changed the title WIP: Display error returned by ollama feat: Display error returned by ollama Dec 13, 2023
@tjbck tjbck merged commit 763448b into open-webui:main Dec 13, 2023
@therohitdas therohitdas deleted the display-error branch December 14, 2023 06:32
explorigin pushed a commit to explorigin/open-webui that referenced this pull request Feb 2, 2024
feat: Display error returned by ollama
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Errors are not getting displayed

2 participants