Skip to content

Comments

fix: duplicate upload error#19586

Closed
Classic298 wants to merge 1 commit intoopen-webui:devfrom
Classic298:fix-false-duplicate-issue
Closed

fix: duplicate upload error#19586
Classic298 wants to merge 1 commit intoopen-webui:devfrom
Classic298:fix-false-duplicate-issue

Conversation

@Classic298
Copy link
Collaborator

  • Target branch: Verify that the pull request targets the dev branch. Not targeting the dev branch will lead to immediate closure of the PR.
  • Description: Provide a concise description of the changes made in this pull request down below.
  • Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
  • Documentation: If necessary, update relevant documentation Open WebUI Docs like environment variables, the tutorials, or other documentation sources.
  • Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
  • Testing: Perform manual tests to verify the implemented fix/feature works as intended AND does not break any other functionality. Take this as an opportunity to make screenshots of the feature/fix and include it in the PR description.
  • Agentic AI Code: Confirm this Pull Request is not written by any AI Agent or has at least gone through additional human review AND manual testing. If any AI Agent is the co-author of this PR, it may lead to immediate closure of the PR.
  • Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
  • Title Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
    • fix: Bug fix or error correction

Changelog Entry

Description

Fixes: #18119
Fixes: #16345
Fixes: #17088
Fixes: #18485

Changed

  • When adding files to a knowledgebase, the check for duplicates is bypassed and allows duplicate uploads

I have tried analyzing the relevant parts of the retrieval.py and knowledge.py but could not identify the actual issue.
This is because the current check for duplicates is broken for two reasons:

  • When adding totally different files THAT YOU HAVE NEVER ADDED before you CAN still get the duplication error
  • Vectors are never deleted from the database, making any duplication checks or hash checks solely based on the content and stored FTS content of the files obsolete

This PR was tested locally with chromadb.sqlite and a locally sqlite MILVUS database and was verified working versus without the fix.

  • [Attach any relevant screenshots or videos demonstrating the changes]

Contributor License Agreement

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

Note

Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.

@pr-validator-bot
Copy link

👋 Welcome and Thank You for Contributing!

We appreciate you taking the time to submit a pull request to Open WebUI!

⚠️ Important: Testing Requirements

We've recently seen an increase in PRs that have significant issues:

  • PRs that don't actually fix the bug they claim to fix
  • PRs that don't implement the feature they describe
  • PRs that break existing functionality
  • PRs that are clearly AI-generated without proper testing being done by the author
  • PRs that simply don't work as intended

These untested PRs consume significant time from maintainers and volunteer contributors who review and test PRs in their free time.
Time that could be spent testing other PRs or improving Open WebUI in other ways.

Before marking your PR as "Ready for Review":

Please explicitly confirm:

  1. ✅ You have personally tested ALL changes in this PR
  2. How you tested it (specific steps you took to verify it works)
  3. Visual evidence where applicable (screenshots or videos showing the feature/fix working) - if applicable to your specific PR

If you're not certain your PR works exactly as intended, please leave it in DRAFT mode until you've thoroughly tested it.

Thank you for helping us maintain quality and respecting the time of our community! 🙏

@Classic298 Classic298 changed the title fix: workspace shared model list fix: duplicate upload error Nov 29, 2025
@tjbck tjbck closed this Nov 29, 2025
@Classic298 Classic298 deleted the fix-false-duplicate-issue branch November 29, 2025 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants