fix: NOTES: Fix broken message submission to completions endpoin#19079
Closed
Classic298 wants to merge 2 commits intoopen-webui:devfrom
Closed
fix: NOTES: Fix broken message submission to completions endpoin#19079Classic298 wants to merge 2 commits intoopen-webui:devfrom
Classic298 wants to merge 2 commits intoopen-webui:devfrom
Conversation
9 tasks
Collaborator
Author
|
fixed in dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before submitting, make sure you've checked the following:
devbranch. Not targeting thedevbranch will lead to immediate closure of the PR.Changelog Entry
Description
This PR fixes a bug in the Notes Chat feature that caused 400 Bad Request errors when sending messages to AI models. The issue was caused by internal UI state fields being incorrectly included in API requests.
Root Cause:* The Notes Chat feature was creating placeholder assistant messages with internal UI state fields (
done: false) for streaming response management. These messages were being sent directly to the API without sanitization, violating the OpenAI message format specification.Solution: Implemented a message cleaning pipeline that:
Changed
Contributor License Agreement
By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.
Note
Deleting the CLA section will lead to immediate closure of your PR and it will not be merged in.