Skip to content

Comments

Fix manifest duplicate crossorigin#18413

Merged
tjbck merged 1 commit intoopen-webui:devfrom
zhsh-12:fix-manifest-duplicate-crossorigin
Oct 19, 2025
Merged

Fix manifest duplicate crossorigin#18413
tjbck merged 1 commit intoopen-webui:devfrom
zhsh-12:fix-manifest-duplicate-crossorigin

Conversation

@zhsh-12
Copy link
Contributor

@zhsh-12 zhsh-12 commented Oct 18, 2025

Pull Request Checklist

Note to first-time contributors: Please open a discussion post in Discussions and describe your changes before submitting a pull request.

Before submitting, make sure you've checked the following:

  • Target branch: Verify that the pull request targets the dev branch. Not targeting the dev branch may lead to immediate closure of the PR.
  • Description: Provide a concise description of the changes made in this pull request.
  • Changelog: Ensure a changelog entry following the format of Keep a Changelog is added at the bottom of the PR description.
  • Documentation: If necessary, update relevant documentation Open WebUI Docs like environment variables, the tutorials, or other documentation sources.
  • Dependencies: Are there any new dependencies? Have you updated the dependency versions in the documentation?
  • Testing: Perform manual tests to verify the implemented fix/feature works as intended AND does not break any other functionality. Take this as an opportunity to make screenshots of the feature/fix and include it in the PR description.
  • Agentic AI Code:: Confirm this Pull Request is not written by any AI Agent or has at least gone through additional human review and manual testing. If any AI Agent is the co-author of this PR, it may lead to immediate closure of the PR.
  • Code review: Have you performed a self-review of your code, addressing any coding standard issues and ensuring adherence to the project's coding standards?
  • Title Prefix: To clearly categorize this pull request, prefix the pull request title using one of the following:
    • BREAKING CHANGE: Significant changes that may affect compatibility
    • build: Changes that affect the build system or external dependencies
    • ci: Changes to our continuous integration processes or workflows
    • chore: Refactor, cleanup, or other non-functional code changes
    • docs: Documentation update or addition
    • feat: Introduces a new feature or enhancement to the codebase
    • fix: Bug fix or error correction
    • i18n: Internationalization or localization changes
    • perf: Performance improvement
    • refactor: Code restructuring for better maintainability, readability, or scalability
    • style: Changes that do not affect the meaning of the code (white space, formatting, missing semi-colons, etc.)
    • test: Adding missing tests or correcting existing tests
    • WIP: Work in progress, a temporary label for incomplete or ongoing work

Changelog Entry

Description

  • [Found a duplicate crossorigin and has it removed]

By submitting this pull request, I confirm that I have read and fully agree to the Contributor License Agreement (CLA), and I am providing my contributions under its terms.

@zhsh-12 zhsh-12 closed this Oct 18, 2025
@zhsh-12 zhsh-12 reopened this Oct 18, 2025
@taylorwilsdon
Copy link
Contributor

taylorwilsdon commented Oct 18, 2025

Need to point the merge at the dev branch for this to be reviewed @zhsh-12

@zhsh-12 zhsh-12 changed the base branch from main to dev October 19, 2025 01:01
@zhsh-12
Copy link
Contributor Author

zhsh-12 commented Oct 19, 2025

Need to point the merge at the dev branch for this to be reviewed @zhsh-12

Has changed, thanks for your notice!

Copy link
Collaborator

@silentoplayz silentoplayz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now after the target branch was swapped to dev!

@tjbck
Copy link
Contributor

tjbck commented Oct 19, 2025

Thanks!

@tjbck tjbck merged commit 6910127 into open-webui:dev Oct 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants