V2 Resolved Schema#980
Merged
Merged
Conversation
lmolkova
reviewed
Oct 14, 2025
lmolkova
left a comment
lmolkova
left a comment
Member
There was a problem hiding this comment.
left some comments, but looks great overall!
lquerel
reviewed
Oct 17, 2025
lquerel
left a comment
lquerel
left a comment
Contributor
There was a problem hiding this comment.
Wow, it took me quite some time to go through all of this. Thanks for the massive refactoring of the semconv schema and everything that comes with it!
Sorry for the number of comments. A lot of them are just copy/paste issues or typos. There are probably only a handful that really concern the approach or the decisions made. Apologies in advance if some of these points or answers have already been discussed in the SIG meetings; I haven't been very present in those lately.
…pans, no real tests.
…creating V2 schema.
jsuereth
force-pushed
the
wip-v2-resolved-schema
branch
from
October 20, 2025 19:25
67e6762 to
209883f
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
clippy found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #980 +/- ##
=======================================
+ Coverage 78.3% 78.5% +0.2%
=======================================
Files 77 82 +5
Lines 6122 6564 +442
=======================================
+ Hits 4795 5156 +361
- Misses 1327 1408 +81 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…vert resolved schema to v2.
jsuereth
marked this pull request as ready for review
November 3, 2025 21:08
Member
|
testing this out on semconv and checking against problems identified for v1 in open-telemetry/semantic-conventions#2469 works fine now ! |
This comment was marked as resolved.
This comment was marked as resolved.
lmolkova
approved these changes
Nov 4, 2025
lmolkova
left a comment
lmolkova
left a comment
Member
There was a problem hiding this comment.
I tested weaver registry resolve --v2 and it works. I'm in favor of merging it and following up
…r testing (which codecov doesn't see).
jerbly
reviewed
Nov 14, 2025
jerbly
approved these changes
Nov 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ready for review
This modifies the resolved telemetry schema (and template values) to look like the V2 definition schema.
With this PR you can resolve into the new schema via a new flag to check how it looks, e.g.
Here's a sample of the new layout: